Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js

Issue 2847893002: fix #27258, don't allow dynamic set of a final field (Closed)
Patch Set: format Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js
diff --git a/pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js b/pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js
index 7a8aed4046d87ca2c573f542d7d931ab6d0d0cec..6692e4b04155e68cc68c02a0ad44d18d54409409 100644
--- a/pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js
+++ b/pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js
@@ -101,9 +101,9 @@ define(['dart_sdk'], function(dart_sdk) {
const radius$ = Symbol("Circle.radius");
dart.setSignature(circle.Circle, {
fields: () => ({
- x: core.num,
- y: core.num,
- radius: core.num
+ x: dart.finalFieldType(core.num),
+ y: dart.finalFieldType(core.num),
+ radius: dart.finalFieldType(core.num)
})
});
painter.CirclePainter = class CirclePainter extends core.Object {
@@ -130,7 +130,7 @@ define(['dart_sdk'], function(dart_sdk) {
const color = Symbol("CirclePainter.color");
painter.CirclePainter[dart.implements] = () => [circle.Circle];
dart.setSignature(painter.CirclePainter, {
- fields: () => ({color: core.String}),
+ fields: () => ({color: dart.fieldType(core.String)}),
methods: () => ({draw: dart.definiteFunctionType(dart.void, [html.CanvasRenderingContext2D])})
});
sunflower.SunflowerSeed = class SunflowerSeed extends dart.mixin(circle.Circle, painter.CirclePainter) {
« no previous file with comments | « pkg/dev_compiler/test/codegen_expected/closure.js ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698