Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2847823005: Revert "Revert of 📺 Move fullscreen web content to a new Activity. (patchset #11 id:200001 of https… (Closed)

Created:
3 years, 7 months ago by PEConn
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of 📺 Move fullscreen web content to a new Activity. (patchset #11 id:200001 of https://codereview.chromium.org/2807663002/ )" This reverts commit d0f88cff6e2cdbb91e95d28c66552a9d5035c5e5. TBR=bauerb@chromium.org BUG=709042 Review-Url: https://codereview.chromium.org/2847823005 Cr-Commit-Position: refs/heads/master@{#467948} Committed: https://chromium.googlesource.com/chromium/src/+/bfc0325cc6193c55fdcd340dfbe87bcc04e4a6ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -27 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java View 1 chunk +107 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 4 chunks +16 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java View 7 chunks +13 lines, -19 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenWebContentsActivityTest.java View 1 chunk +160 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
PEConn
Mounir, your CL clobbered mine >:-( . Updating the constant name and relanding.
3 years, 7 months ago (2017-04-28 08:43:56 UTC) #3
mlamouri (slow - plz ping)
Sorry about that :( lgtm though \o/
3 years, 7 months ago (2017-04-28 08:46:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847823005/1
3 years, 7 months ago (2017-04-28 10:15:32 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 10:20:12 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bfc0325cc6193c55fdcd340dfbe8...

Powered by Google App Engine
This is Rietveld 408576698