|
|
Created:
3 years, 7 months ago by ncarter (slow) Modified:
3 years, 7 months ago Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionExtensionNavigationThrottle: No platform apps in normal tabs.
This restriction already exists, but there were several ways around
it. The blockage in chrome::Navigate only applied to
browser-initiated navigations; the blockage in the CreateNewWindow
codepath only applied to the initially-requested URL.
This prevents the following scenarios:
(1) a platform app's background page could open a popup
with window.open(), and then navigate it back to
a platform app resource.
(2) A browser-initiated navigation could be issued to an
http URL that redirects to a platform app URL.
The only remaining hole I'm aware of is the following scenario:
(3) a platform app's background page can open an
about:blank popup with window.open()
That last case will be fixed in the next patch.
BUG=139258, 708870
Patch Set 1 #Patch Set 2 : Merge branch 'kill_107_reboot3' into kill_107_reboot4 #Patch Set 3 : Rebase #Patch Set 4 : Merge branch 'kill_107_reboot4' into kill_107_reboot4' #Patch Set 5 : Merge branch 'kill_107_reboot3'' into kill_107_reboot4' #
Depends on Patchset: Messages
Total messages: 27 (27 generated)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ExtensionNavigationThrottle: No platform apps in normal tabs. BUG=708870 ========== to ========== ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already exists, but there were several ways around it. The blockage in chrome::Navigate only applied to browser-initiated navigations; the blockage in the CreateNewWindow codepath only applied to the initially-requested URL. This prevents the following scenarios: (1) a platform app's background page could open a popup with window.open(), and then navigate it back to a platform app resource. (2) A browser-initiated navigation could be issued to an http URL that redirects to a platform app URL. The only remaining hole I'm aware of is the following scenario: (3) a platform app's background page can open an about:blank popup with window.open() That will be addressed in the next patch. BUG=708870 ==========
Description was changed from ========== ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already exists, but there were several ways around it. The blockage in chrome::Navigate only applied to browser-initiated navigations; the blockage in the CreateNewWindow codepath only applied to the initially-requested URL. This prevents the following scenarios: (1) a platform app's background page could open a popup with window.open(), and then navigate it back to a platform app resource. (2) A browser-initiated navigation could be issued to an http URL that redirects to a platform app URL. The only remaining hole I'm aware of is the following scenario: (3) a platform app's background page can open an about:blank popup with window.open() That will be addressed in the next patch. BUG=708870 ========== to ========== ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already exists, but there were several ways around it. The blockage in chrome::Navigate only applied to browser-initiated navigations; the blockage in the CreateNewWindow codepath only applied to the initially-requested URL. This prevents the following scenarios: (1) a platform app's background page could open a popup with window.open(), and then navigate it back to a platform app resource. (2) A browser-initiated navigation could be issued to an http URL that redirects to a platform app URL. The only remaining hole I'm aware of is the following scenario: (3) a platform app's background page can open an about:blank popup with window.open() That last case will be fixed in the next patch. BUG=708870 ==========
Description was changed from ========== ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already exists, but there were several ways around it. The blockage in chrome::Navigate only applied to browser-initiated navigations; the blockage in the CreateNewWindow codepath only applied to the initially-requested URL. This prevents the following scenarios: (1) a platform app's background page could open a popup with window.open(), and then navigate it back to a platform app resource. (2) A browser-initiated navigation could be issued to an http URL that redirects to a platform app URL. The only remaining hole I'm aware of is the following scenario: (3) a platform app's background page can open an about:blank popup with window.open() That last case will be fixed in the next patch. BUG=708870 ========== to ========== ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already exists, but there were several ways around it. The blockage in chrome::Navigate only applied to browser-initiated navigations; the blockage in the CreateNewWindow codepath only applied to the initially-requested URL. This prevents the following scenarios: (1) a platform app's background page could open a popup with window.open(), and then navigate it back to a platform app resource. (2) A browser-initiated navigation could be issued to an http URL that redirects to a platform app URL. The only remaining hole I'm aware of is the following scenario: (3) a platform app's background page can open an about:blank popup with window.open() That last case will be fixed in the next patch. BUG=139258, 708870 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) |