Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2847803004: ExtensionNavigationThrottle: No platform apps in normal tabs.

Created:
3 years, 7 months ago by ncarter (slow)
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already exists, but there were several ways around it. The blockage in chrome::Navigate only applied to browser-initiated navigations; the blockage in the CreateNewWindow codepath only applied to the initially-requested URL. This prevents the following scenarios: (1) a platform app's background page could open a popup with window.open(), and then navigate it back to a platform app resource. (2) A browser-initiated navigation could be issued to an http URL that redirects to a platform app URL. The only remaining hole I'm aware of is the following scenario: (3) a platform app's background page can open an about:blank popup with window.open() That last case will be fixed in the next patch. BUG=139258, 708870

Patch Set 1 #

Patch Set 2 : Merge branch 'kill_107_reboot3' into kill_107_reboot4 #

Patch Set 3 : Rebase #

Patch Set 4 : Merge branch 'kill_107_reboot4' into kill_107_reboot4' #

Patch Set 5 : Merge branch 'kill_107_reboot3'' into kill_107_reboot4' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M chrome/browser/ui/browser_navigator.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M extensions/browser/extension_navigation_throttle.cc View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (27 generated)
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-27 22:05:15 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847803004/1
3 years, 7 months ago (2017-04-27 22:29:55 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-28 01:36:22 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/358970) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 7 months ago (2017-04-28 01:36:23 UTC) #4
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-28 17:27:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847803004/20001
3 years, 7 months ago (2017-04-28 17:28:06 UTC) #6
ncarter (slow)
Description was changed from ========== ExtensionNavigationThrottle: No platform apps in normal tabs. BUG=708870 ========== to ...
3 years, 7 months ago (2017-04-28 17:33:10 UTC) #7
ncarter (slow)
Description was changed from ========== ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already ...
3 years, 7 months ago (2017-04-28 17:34:17 UTC) #8
ncarter (slow)
Description was changed from ========== ExtensionNavigationThrottle: No platform apps in normal tabs. This restriction already ...
3 years, 7 months ago (2017-04-28 17:40:21 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-28 18:15:31 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/415233)
3 years, 7 months ago (2017-04-28 18:15:31 UTC) #11
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 21:58:48 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847803004/40001
3 years, 7 months ago (2017-05-01 21:59:44 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-01 22:45:42 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/443010)
3 years, 7 months ago (2017-05-01 22:45:43 UTC) #15
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 20:57:32 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847803004/60001
3 years, 7 months ago (2017-05-17 20:59:12 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 23:13:25 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429666)
3 years, 7 months ago (2017-05-17 23:13:26 UTC) #19
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 23:05:25 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847803004/80001
3 years, 7 months ago (2017-05-22 23:06:18 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 23:15:36 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/424872) mac_chromium_rel_ng on ...
3 years, 7 months ago (2017-05-22 23:15:37 UTC) #23
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 22:04:23 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847803004/80001
3 years, 7 months ago (2017-05-26 22:04:59 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 23:25:04 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 23:25:05 UTC) #27
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698