Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2841413003:
ExtensionNavigationThrottle: block extension iframes in platform apps. (Closed)
|
Created:
3 years, 7 months ago by ncarter (slow) Modified:
3 years, 7 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionExtensionNavigationThrottle: block extension iframes in platform apps.
This should fix instances of [Renderer kill 106] and
[Renderer kill 107], which are kills due to transferring
a subframe to a different storage partition from its parent.
BUG=694231, 693720
Review-Url: https://codereview.chromium.org/2841413003
Cr-Commit-Position: refs/heads/master@{#474352}
Committed: https://chromium.googlesource.com/chromium/src/+/962729847c531a6650831995d687080fc567c809
Patch Set 1 #Patch Set 2 : Merge branch 'kill_107_reboot2' into kill_107_reboot3 #Patch Set 3 : Things. #Patch Set 4 : Things. #Patch Set 5 : Rebase #
Total comments: 1
Patch Set 6 : Merge branch 'kill_107_reboot3' into kill_107_reboot3' #Patch Set 7 : Merge branch 'kill_107_reboot2_s' into kill_107_reboot3' #Patch Set 8 : Merge branch 'kill_107_reboot2_s' into kill_107_reboot3' #Messages
Total messages: 39 (34 generated)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ExtensionNavigationThrottle: block extension iframes in platform apps. BUG=694231,693720 ========== to ========== ExtensionNavigationThrottle: block extension iframes in platform apps. This should fix instances of [Renderer kill 106] and [Renderer kill 107], which are kills when we try to transfer a subframe to a different storage partition from its parent. BUG=694231,693720 ==========
Description was changed from ========== ExtensionNavigationThrottle: block extension iframes in platform apps. This should fix instances of [Renderer kill 106] and [Renderer kill 107], which are kills when we try to transfer a subframe to a different storage partition from its parent. BUG=694231,693720 ========== to ========== ExtensionNavigationThrottle: block extension iframes in platform apps. This should fix instances of [Renderer kill 106] and [Renderer kill 107], which are kills due to transferring a subframe to a different storage partition from its parent. BUG=694231,693720 ==========
Description was changed from ========== ExtensionNavigationThrottle: block extension iframes in platform apps. This should fix instances of [Renderer kill 106] and [Renderer kill 107], which are kills due to transferring a subframe to a different storage partition from its parent. BUG=694231,693720 ========== to ========== ExtensionNavigationThrottle: block extension iframes in platform apps. This should fix instances of [Renderer kill 106] and [Renderer kill 107], which are kills due to transferring a subframe to a different storage partition from its parent. BUG=694231,693720 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
nick@chromium.org changed reviewers: + nasko@chromium.org, rdevlin.cronin@chromium.org
nasko, devlin: please review
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, but a test sure would look nice with this CL ;) https://codereview.chromium.org/2841413003/diff/80001/extensions/browser/exte... File extensions/browser/extension_navigation_throttle.cc (right): https://codereview.chromium.org/2841413003/diff/80001/extensions/browser/exte... extensions/browser/extension_navigation_throttle.cc:172: return content::NavigationThrottle::BLOCK_REQUEST; Document why the BLOCK vs CANCEL?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
LGTM
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2841413003/#ps140001 (title: "Merge branch 'kill_107_reboot2_s' into kill_107_reboot3'")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1495645903338510,
"parent_rev": "0b5ea9ecfced144635473431fd2870e6328bd3fb", "commit_rev":
"962729847c531a6650831995d687080fc567c809"}
Message was sent while issue was closed.
Description was changed from ========== ExtensionNavigationThrottle: block extension iframes in platform apps. This should fix instances of [Renderer kill 106] and [Renderer kill 107], which are kills due to transferring a subframe to a different storage partition from its parent. BUG=694231,693720 ========== to ========== ExtensionNavigationThrottle: block extension iframes in platform apps. This should fix instances of [Renderer kill 106] and [Renderer kill 107], which are kills due to transferring a subframe to a different storage partition from its parent. BUG=694231,693720 Review-Url: https://codereview.chromium.org/2841413003 Cr-Commit-Position: refs/heads/master@{#474352} Committed: https://chromium.googlesource.com/chromium/src/+/962729847c531a6650831995d687... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/src/+/962729847c531a6650831995d687... |
