Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2847683002: [ia32] Add cmpps/vcmpps for eq/lt/le/neq (Closed)

Created:
3 years, 7 months ago by Jing
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, bbudge
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Add cmpps/vcmpps for eq/lt/le/neq BUG= Review-Url: https://codereview.chromium.org/2847683002 Cr-Commit-Position: refs/heads/master@{#44955} Committed: https://chromium.googlesource.com/v8/v8/+/0e0e1aa81a1d351d7824618a6657c36f0647b3b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M src/ia32/assembler-ia32.h View 2 chunks +31 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jing
3 years, 7 months ago (2017-04-27 11:38:57 UTC) #2
bbudge
lgtm
3 years, 7 months ago (2017-04-27 17:30:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847683002/1
3 years, 7 months ago (2017-04-28 01:34:53 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 01:56:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0e0e1aa81a1d351d7824618a6657c36f064...

Powered by Google App Engine
This is Rietveld 408576698