Revert of HttpCache::Transaction layer allowing parallel validation

Revert of HttpCache::Transaction layer allowing parallel validation (patchset #33 id:800001 of https://codereview.chromium.org/2721933002/ )

Reason for revert:
Breaks tricky-tot-chrome-pfq-informational audio_CrasSanity autotest: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/tricky-tot-chrome-pfq-informational/builds/4271

Original issue's description:
> This CL is a precursor to allowing shared writing to fix cache lock.
> 
> This CL allows transactions to continue to their validation phase even when another
> transaction is the active reader/writer. After the validation phase, if its a match
> the transaction might wait till the response is written to the cache by the active 
> writer. If its not a match the transaction will doom the entry and go to the 
> network. In a subsequent CL, the not matching case will create a new entry as well.
> 
> BUG=472740
> 
> Review-Url: https://codereview.chromium.org/2721933002
> Cr-Commit-Position: refs/heads/master@{#467426}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e2e347f957ef889aaee527bb757849f76e8a808

TBR=asanka@chromium.org,jkarlin@chromium.org,rdsmith@chromium.org,shivanisha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472740
Review-Url: https://codereview.chromium.org/2847653002
Cr-Commit-Position: refs/heads/master@{#467556}
Committed: https://chromium.googlesource.com/chromium/src/+/ae7fa093c74907efb6c2788208ac05495e960936

[Qiang(Joe) Xu, 2017-04-27 02:45:01]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2017-04-27 02:45:02]

Created Revert of HttpCache::Transaction layer allowing parallel validation

[commit-bot: I haz the power, 2017-04-27 02:45:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 02:46:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493261101719320, "parent_rev":
"ee03de14cb653c1e21ea4df5499a9fc183d9a921", "commit_rev":
"ae7fa093c74907efb6c2788208ac05495e960936"}

[commit-bot: I haz the power, 2017-04-27 02:46:19]

Description was changed from

==========
Revert of HttpCache::Transaction layer allowing parallel validation (patchset
#33 id:800001 of https://codereview.chromium.org/2721933002/ )

Reason for revert:
Breaks tricky-tot-chrome-pfq-informational audio_CrasSanity autotest:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/tricky-tot-ch...

Original issue's description:
> This CL is a precursor to allowing shared writing to fix cache lock.
> 
> This CL allows transactions to continue to their validation phase even when
another
> transaction is the active reader/writer. After the validation phase, if its a
match
> the transaction might wait till the response is written to the cache by the
active 
> writer. If its not a match the transaction will doom the entry and go to the 
> network. In a subsequent CL, the not matching case will create a new entry as
well.
> 
> BUG=472740
> 
> Review-Url: https://codereview.chromium.org/2721933002
> Cr-Commit-Position: refs/heads/master@{#467426}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1e2e347f957ef889aaee527bb757...

TBR=asanka@chromium.org,jkarlin@chromium.org,rdsmith@chromium.org,shivanisha@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472740
==========

to

==========
Revert of HttpCache::Transaction layer allowing parallel validation (patchset
#33 id:800001 of https://codereview.chromium.org/2721933002/ )

Reason for revert:
Breaks tricky-tot-chrome-pfq-informational audio_CrasSanity autotest:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/tricky-tot-ch...

Original issue's description:
> This CL is a precursor to allowing shared writing to fix cache lock.
> 
> This CL allows transactions to continue to their validation phase even when
another
> transaction is the active reader/writer. After the validation phase, if its a
match
> the transaction might wait till the response is written to the cache by the
active 
> writer. If its not a match the transaction will doom the entry and go to the 
> network. In a subsequent CL, the not matching case will create a new entry as
well.
> 
> BUG=472740
> 
> Review-Url: https://codereview.chromium.org/2721933002
> Cr-Commit-Position: refs/heads/master@{#467426}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1e2e347f957ef889aaee527bb757...

TBR=asanka@chromium.org,jkarlin@chromium.org,rdsmith@chromium.org,shivanisha@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472740

Review-Url: https://codereview.chromium.org/2847653002
Cr-Commit-Position: refs/heads/master@{#467556}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae7fa093c74907efb6c2788208ac...
==========

[commit-bot: I haz the power, 2017-04-27 02:46:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae7fa093c74907efb6c2788208ac...

[asanka, 2017-04-27 03:27:37]

warx: Could you explain the following:
* What is this bot? (configuration, and what tests is it running)
* Which specific failure are you referring to? The log you linked is pretty much
unreadable.
* Is there a trybot people can use that has the same configuration as this bot?

[Qiang(Joe) Xu, 2017-04-27 06:44:16]

They (I also see failure on peach_pit board) are selected client boards
that run tot chrome with latest Chrome OS version. The test failures are
hardware auto-test.

Your CL might affect how this test runs. But I am not sure how right now.
Might be here:
https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/cli...

I will help contact code owner tomorrow for identifying how it is related.

I don't think there is a trybot to detect this until you cl is landed. You
can do local autotest if you have a chromeos checkout and setup.

I have seen the boards turning green now. We can work together to find why
it fails the test.

On Wed, Apr 26, 2017 at 8:27 PM, <asanka@chromium.org> wrote:

> warx: Could you explain the following:
> * What is this bot? (configuration, and what tests is it running)
> * Which specific failure are you referring to? The log you linked is
> pretty much
> unreadable.
> * Is there a trybot people can use that has the same configuration as this
> bot?
>
> https://codereview.chromium.org/2847653002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vitaliii, 2017-04-27 06:44:42]

On 2017/04/27 03:27:37, asanka wrote:
> warx: Could you explain the following:
> * What is this bot? (configuration, and what tests is it running)
> * Which specific failure are you referring to? The log you linked is pretty
much
> unreadable.
> * Is there a trybot people can use that has the same configuration as this
bot?

That CL also broke chromium.memory/Linux Chromium OS ASan LSan Tests.
Please see https://bugs.chromium.org/p/chromium/issues/detail?id=715911 for more
info.
The build became immediately green when this revert landed.

[vitaliii, 2017-04-27 08:13:00]

On 2017/04/27 06:44:42, vitaliii wrote:
> On 2017/04/27 03:27:37, asanka wrote:
> > warx: Could you explain the following:
> > * What is this bot? (configuration, and what tests is it running)
> > * Which specific failure are you referring to? The log you linked is pretty
> much
> > unreadable.
> > * Is there a trybot people can use that has the same configuration as this
> bot?
> 
> That CL also broke chromium.memory/Linux Chromium OS ASan LSan Tests.
> Please see https://bugs.chromium.org/p/chromium/issues/detail?id=715911 for
more
> info.
> The build became immediately green when this revert landed.

Same for https://bugs.chromium.org/p/chromium/issues/detail?id=715920.

[asanka, 2017-04-27 13:28:59]

On 2017/04/27 08:13:00, vitaliii wrote:
> On 2017/04/27 06:44:42, vitaliii wrote:
> > On 2017/04/27 03:27:37, asanka wrote:
> > > warx: Could you explain the following:
> > > * What is this bot? (configuration, and what tests is it running)
> > > * Which specific failure are you referring to? The log you linked is
pretty
> > much
> > > unreadable.
> > > * Is there a trybot people can use that has the same configuration as this
> > bot?
> > 
> > That CL also broke chromium.memory/Linux Chromium OS ASan LSan Tests.
> > Please see https://bugs.chromium.org/p/chromium/issues/detail?id=715911 for
> more
> > info.
> > The build became immediately green when this revert landed.
> 
> Same for https://bugs.chromium.org/p/chromium/issues/detail?id=715920.

warx: Thanks for the feedback! Assuming this is catching a real regression
independent of the memory errors, it would be great to dig into what happened.
Shall we follow up on a bug so that we can continue the conversation there?
Specially since this specific test cannot be reproduced or verified without
special instructions.
vitaliii: Thanks for the relevant pointers.