Index: net/http/http_cache.h |
diff --git a/net/http/http_cache.h b/net/http/http_cache.h |
index ca8ba08f254bf1c5ca63df8e9141eb7484fd27cc..635cb92d557d17c6c60ca459f4117deb075f71f7 100644 |
--- a/net/http/http_cache.h |
+++ b/net/http/http_cache.h |
@@ -244,31 +244,9 @@ |
friend class ViewCacheHelper; |
struct PendingOp; // Info for an entry under construction. |
- // To help with testing. |
- friend class MockHttpCache; |
- |
using TransactionList = std::list<Transaction*>; |
using TransactionSet = std::unordered_set<Transaction*>; |
typedef std::list<std::unique_ptr<WorkItem>> WorkItemList; |
- |
- // We implement a basic reader/writer lock for the disk cache entry. If there |
- // is a writer, then all transactions must wait to read the body. But the |
- // waiting transactions can start their headers phase in parallel. Headers |
- // phase is allowed for one transaction at a time so that if it doesn't match |
- // the existing headers, remaining transactions do not also try to match the |
- // existing entry in parallel leading to wasted network requests. If the |
- // headers do not match, this entry will be doomed. |
- // |
- // A transaction goes through these state transitions. |
- // |
- // Write mode transactions: |
- // add_to_entry_queue-> headers_transaction -> writer |
- // add_to_entry_queue-> headers_transaction -> done_headers_queue -> readers |
- // (once the data is written to the cache by another writer) |
- // |
- // Read only transactions: |
- // add_to_entry_queue-> headers_transaction -> done_headers_queue -> readers |
- // (once the data is written to the cache by the writer) |
struct ActiveEntry { |
explicit ActiveEntry(disk_cache::Entry* entry); |
@@ -278,36 +256,12 @@ |
// Returns true if no transactions are associated with this entry. |
bool HasNoTransactions(); |
- // Returns true if no active readers/writer transactions are associated |
- // with this entry. |
- bool HasNoActiveTransactions(); |
- |
- disk_cache::Entry* disk_entry = nullptr; |
- |
- // Transactions waiting to be added to entry. |
- TransactionList add_to_entry_queue; |
- |
- // Transaction currently in the headers phase, either validating the |
- // response or getting new headers. This can exist simultaneously with |
- // writer or readers while validating existing headers. |
- Transaction* headers_transaction = nullptr; |
- |
- // Transactions that have completed their headers phase and are waiting |
- // to read the response body or write the response body. |
- TransactionList done_headers_queue; |
- |
- // Transaction currently reading from the network and writing to the cache. |
- Transaction* writer = nullptr; |
- |
- // Transactions that can only read from the cache. Only one of writer or |
- // readers can exist at a time. |
+ disk_cache::Entry* disk_entry; |
+ Transaction* writer; |
TransactionSet readers; |
- |
- // The following variables are true if OnProcessQueuedTransactions is posted |
- bool will_process_queued_transactions = false; |
- |
- // True if entry is doomed. |
- bool doomed = false; |
+ TransactionList pending_queue; |
+ bool will_process_pending_queue; |
+ bool doomed; |
}; |
using ActiveEntriesMap = |
@@ -388,73 +342,28 @@ |
// Destroys an ActiveEntry (active or doomed). |
void DestroyEntry(ActiveEntry* entry); |
- // Adds a transaction to an ActiveEntry. This method returns ERR_IO_PENDING |
- // and the transaction will be notified about completion via its IO callback. |
- // In a failure case, the callback will be invoked with ERR_CACHE_RACE. |
- int AddTransactionToEntry(ActiveEntry* entry, Transaction* transaction); |
- |
- // Transaction invokes this when its response headers phase is complete |
- // If the transaction is responsible for writing the response body, |
- // it becomes the writer and returns OK. In other cases ERR_IO_PENDING is |
- // returned and the transaction will be notified about completion via its |
- // IO callback. In a failure case, the callback will be invoked with |
- // ERR_CACHE_RACE. |
- int DoneWithResponseHeaders(ActiveEntry* entry, Transaction* transaction); |
+ // Adds a transaction to an ActiveEntry. If this method returns ERR_IO_PENDING |
+ // the transaction will be notified about completion via its IO callback. This |
+ // method returns ERR_CACHE_RACE to signal the transaction that it cannot be |
+ // added to the provided entry, and it should retry the process with another |
+ // one (in this case, the entry is no longer valid). |
+ int AddTransactionToEntry(ActiveEntry* entry, Transaction* trans); |
// Called when the transaction has finished working with this entry. |cancel| |
// is true if the operation was cancelled by the caller instead of running |
// to completion. |
- void DoneWithEntry(ActiveEntry* entry, Transaction* transaction, bool cancel); |
+ void DoneWithEntry(ActiveEntry* entry, Transaction* trans, bool cancel); |
// Called when the transaction has finished writing to this entry. |success| |
// is false if the cache entry should be deleted. |
- void DoneWritingToEntry(ActiveEntry* entry, |
- bool success, |
- Transaction* transaction); |
+ void DoneWritingToEntry(ActiveEntry* entry, bool success); |
// Called when the transaction has finished reading from this entry. |
- void DoneReadingFromEntry(ActiveEntry* entry, Transaction* transaction); |
- |
- // Removes and returns all queued transactions in |entry| in FIFO order. This |
- // includes transactions that have completed the headers phase and those that |
- // have not been added to the entry yet in that order. |list| is the output |
- // argument. |
- void RemoveAllQueuedTransactions(ActiveEntry* entry, TransactionList* list); |
- |
- // Processes either writer's failure to write response body or |
- // headers_transactions's failure to write headers. Also invoked when headers |
- // transaction's validation result is not a match. |
- void ProcessEntryFailure(ActiveEntry* entry); |
- |
- // Resumes processing the queued transactions of |entry|. |
- void ProcessQueuedTransactions(ActiveEntry* entry); |
- |
- // Checks if a transaction can be added to the entry. If yes, it will |
- // invoke the IO callback of the transaction. This is a helper function for |
- // OnProcessQueuedTransactions. It will take a transaction from |
- // add_to_entry_queue and make it a headers_transaction, if one doesn't exist |
- // already. |
- void ProcessAddToEntryQueue(ActiveEntry* entry); |
- |
- // Invoked when a transaction that has already completed the response headers |
- // phase can resume reading/writing the response body. It will invoke the IO |
- // callback of the transaction. This is a helper function for |
- // OnProcessQueuedTransactions. |
- void ProcessDoneHeadersQueue(ActiveEntry* entry); |
- |
- // Returns true if this transaction can write headers to the entry. |
- bool CanTransactionWriteResponseHeaders(ActiveEntry* entry, |
- Transaction* transaction, |
- bool is_match) const; |
- |
- // Returns true if |transaction| is about to start writing response body or |
- // already started but not yet finished. |
- bool IsTransactionWritingIncomplete(ActiveEntry* entry, |
- Transaction* transaction, |
- const std::string& method) const; |
- |
- // Returns true if a transaction is currently writing the response body. |
- bool IsWritingInProgress(ActiveEntry* entry) const; |
+ void DoneReadingFromEntry(ActiveEntry* entry, Transaction* trans); |
+ |
+ // Converts the active writer transaction to a reader so that other |
+ // transactions can start reading from this entry. |
+ void ConvertWriterToReader(ActiveEntry* entry); |
// Returns the LoadState of the provided pending transaction. |
LoadState GetLoadStateForPendingTransaction(const Transaction* trans); |
@@ -470,10 +379,12 @@ |
// Removes the transaction |trans|, from the pending list of |pending_op|. |
bool RemovePendingTransactionFromPendingOp(PendingOp* pending_op, |
Transaction* trans); |
+ // Resumes processing the pending list of |entry|. |
+ void ProcessPendingQueue(ActiveEntry* entry); |
// Events (called via PostTask) --------------------------------------------- |
- void OnProcessQueuedTransactions(ActiveEntry* entry); |
+ void OnProcessPendingQueue(ActiveEntry* entry); |
// Callbacks ---------------------------------------------------------------- |