Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2077)

Issue 2847603002: Powerwash UI polish (Closed)

Created:
3 years, 8 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 7 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Powerwash UI polish 1. Change popup overlay according to new specs. 2. Change the reset alert icon 3. Other miscellaneous changes (Put powerwash texts in one line etc.) BUG=715851 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2847603002 Cr-Commit-Position: refs/heads/master@{#469242} Committed: https://chromium.googlesource.com/chromium/src/+/809f8b04b5b9e6242bbf7bb8e772def30d538230

Patch Set 1 #

Patch Set 2 : change according to new specs #

Patch Set 3 : Change according to new specs #

Messages

Total messages: 18 (11 generated)
Wenzhao (Colin) Zang
alemate@ please take a look. I recalled from the last CL that after adding 'class="oobe-icon"' ...
3 years, 8 months ago (2017-04-27 00:34:11 UTC) #4
Wenzhao (Colin) Zang
The class in oobe_dialog_parameters.css is added back because although the powerwash page no longer uses ...
3 years, 7 months ago (2017-04-28 05:39:14 UTC) #7
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-01 20:45:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847603002/40001
3 years, 7 months ago (2017-05-04 00:17:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/403073) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-04 00:25:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847603002/40001
3 years, 7 months ago (2017-05-04 00:27:45 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 01:41:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/809f8b04b5b9e6242bbf7bb8e772...

Powered by Google App Engine
This is Rietveld 408576698