Description was changed from ========== Powerwash UI polish BUG=715851 ========== to ========== Powerwash UI polish ...
3 years, 8 months ago
(2017-04-27 00:28:31 UTC)
#1
Description was changed from
==========
Powerwash UI polish
BUG=715851
==========
to
==========
Powerwash UI polish
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
Wenzhao (Colin) Zang
Description was changed from ========== Powerwash UI polish BUG=715851 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Powerwash UI ...
3 years, 8 months ago
(2017-04-27 00:31:18 UTC)
#2
Description was changed from
==========
Powerwash UI polish
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Powerwash UI polish
(1) The top left icon should be a blue exclamation mark. It was a black
'i' as info.
(2) The aspect ratio of the illustration is changed to match the original
design.
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
alemate@ please take a look. I recalled from the last CL that after adding 'class="oobe-icon"' ...
3 years, 8 months ago
(2017-04-27 00:34:11 UTC)
#4
alemate@ please take a look. I recalled from the last CL that after adding
'class="oobe-icon"' the black info icon turns to blue. For some reason, after it
was landed the icon is still black. I'm wondering if the same will happen for
this new icon. I don't see the reason.
Wenzhao (Colin) Zang
Description was changed from ========== Powerwash UI polish (1) The top left icon should be ...
3 years, 7 months ago
(2017-04-28 05:17:31 UTC)
#5
Description was changed from
==========
Powerwash UI polish
(1) The top left icon should be a blue exclamation mark. It was a black
'i' as info.
(2) The aspect ratio of the illustration is changed to match the original
design.
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Powerwash UI polish
Miscellaneous changes (detailed in inline comments)
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
Wenzhao (Colin) Zang
Description was changed from ========== Powerwash UI polish Miscellaneous changes (detailed in inline comments) BUG=715851 ...
3 years, 7 months ago
(2017-04-28 05:34:21 UTC)
#6
Description was changed from
==========
Powerwash UI polish
Miscellaneous changes (detailed in inline comments)
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Powerwash UI polish
1. Change popup overlay according to new specs.
2. Change the reset alert icon
3. Other miscellaneous changes (Put powerwash texts in one line etc.)
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
Wenzhao (Colin) Zang
The class in oobe_dialog_parameters.css is added back because although the powerwash page no longer uses ...
3 years, 7 months ago
(2017-04-28 05:39:14 UTC)
#7
The class in oobe_dialog_parameters.css is added back because although the
powerwash page no longer uses it, there are other pages still using it which
might be affected.
Alexander Alekseev
lgtm
3 years, 7 months ago
(2017-05-01 20:45:31 UTC)
#8
lgtm
Wenzhao (Colin) Zang
The CQ bit was checked by wzang@chromium.org
3 years, 7 months ago
(2017-05-04 00:16:31 UTC)
#9
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/403073) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago
(2017-05-04 00:25:44 UTC)
#13
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493857624436220, "parent_rev": "a5c972c3bc8cec76dd56c93a2991d3d02ad88f43", "commit_rev": "809f8b04b5b9e6242bbf7bb8e772def30d538230"}
3 years, 7 months ago
(2017-05-04 01:40:50 UTC)
#16
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493857624436220,
"parent_rev": "a5c972c3bc8cec76dd56c93a2991d3d02ad88f43", "commit_rev":
"809f8b04b5b9e6242bbf7bb8e772def30d538230"}
commit-bot: I haz the power
Description was changed from ========== Powerwash UI polish 1. Change popup overlay according to new ...
3 years, 7 months ago
(2017-05-04 01:41:02 UTC)
#17
Message was sent while issue was closed.
Description was changed from
==========
Powerwash UI polish
1. Change popup overlay according to new specs.
2. Change the reset alert icon
3. Other miscellaneous changes (Put powerwash texts in one line etc.)
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Powerwash UI polish
1. Change popup overlay according to new specs.
2. Change the reset alert icon
3. Other miscellaneous changes (Put powerwash texts in one line etc.)
BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2847603002
Cr-Commit-Position: refs/heads/master@{#469242}
Committed:
https://chromium.googlesource.com/chromium/src/+/809f8b04b5b9e6242bbf7bb8e772...
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/809f8b04b5b9e6242bbf7bb8e772def30d538230
3 years, 7 months ago
(2017-05-04 01:41:05 UTC)
#18
Issue 2847603002: Powerwash UI polish
(Closed)
Created 3 years, 8 months ago by Wenzhao (Colin) Zang
Modified 3 years, 7 months ago
Reviewers: Alexander Alekseev
Base URL:
Comments: 0