Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2847553004: Revert of Use TaskScheduler instead of blocking pool in file_downloader.cc. (Closed)

Created:
3 years, 7 months ago by vitaliii
Modified:
3 years, 7 months ago
Reviewers:
asanka, fdoray
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of blocking pool in file_downloader.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2835303002/ ) Reason for revert: "FileDownloaderTest.DontOverwrite" is flaky. crbug.com/715964 Original issue's description: > Use TaskScheduler instead of blocking pool in file_downloader.cc. > > The blocking pool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=asanka@chromium.org > > Review-Url: https://codereview.chromium.org/2835303002 > Cr-Commit-Position: refs/heads/master@{#467397} > Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5 TBR=asanka@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892, 715964 Review-Url: https://codereview.chromium.org/2847553004 Cr-Commit-Position: refs/heads/master@{#467638} Committed: https://chromium.googlesource.com/chromium/src/+/dfd5b6f49e5382da44646018e2471a3e9f15f96f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M chrome/browser/net/file_downloader.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/net/file_downloader_unittest.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
vitaliii
Created Revert of Use TaskScheduler instead of blocking pool in file_downloader.cc.
3 years, 7 months ago (2017-04-27 11:32:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847553004/1
3 years, 7 months ago (2017-04-27 11:33:02 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 11:33:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfd5b6f49e5382da44646018e247...

Powered by Google App Engine
This is Rietveld 408576698