|
|
Description[reland] Use TaskScheduler instead of blocking pool in file_downloader.cc.
[The CL seems to have been reverted because of flakes when the
first patch set was sent to the CQ dry run. These flakes were
fixed in the second patch set (the one that landed).]
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=asanka@chromium.org
Review-Url: https://codereview.chromium.org/2835303002
Cr-Original-Commit-Position: refs/heads/master@{#467397}
Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5
Review-Url: https://codereview.chromium.org/2835303002
Cr-Commit-Position: refs/heads/master@{#467641}
Committed: https://chromium.googlesource.com/chromium/src/+/15e8fb8c185a6137e42c895401c127972249d26f
Patch Set 1 #Patch Set 2 : self-review #
Messages
Total messages: 30 (19 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org Link to the patchset: https://codereview.chromium.org/2835303002/#ps20001 (title: "self-review")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493227614234760, "parent_rev": "1fbce15166ac6fdbd967a1249375afdbd711de8e", "commit_rev": "4f0ba69f0ae32dc9e48fc021852585abb0df35b5"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in file_downloader.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in file_downloader.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2847553004/ by vitaliii@chromium.org. The reason for reverting is: "FileDownloaderTest.DontOverwrite" is flaky. crbug.com/715964.
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in file_downloader.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525... ========== to ========== Use TaskScheduler instead of blocking pool in file_downloader.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525... ==========
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by fdoray@chromium.org
Description was changed from ========== Use TaskScheduler instead of blocking pool in file_downloader.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525... ========== to ========== [reland] Use TaskScheduler instead of blocking pool in file_downloader.cc. [The CL seems to have been reverted because of flakes when the first patch set was sent to the CQ dry run. These flakes were fixed in the second patch set (the one that landed).] The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525... ==========
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493294833757710, "parent_rev": "3721c3608a5aef73b1762e6906257c9d9f8e0d36", "commit_rev": "15e8fb8c185a6137e42c895401c127972249d26f"}
Message was sent while issue was closed.
Description was changed from ========== [reland] Use TaskScheduler instead of blocking pool in file_downloader.cc. [The CL seems to have been reverted because of flakes when the first patch set was sent to the CQ dry run. These flakes were fixed in the second patch set (the one that landed).] The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525... ========== to ========== [reland] Use TaskScheduler instead of blocking pool in file_downloader.cc. [The CL seems to have been reverted because of flakes when the first patch set was sent to the CQ dry run. These flakes were fixed in the second patch set (the one that landed).] The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Original-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc0218525... Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467641} Committed: https://chromium.googlesource.com/chromium/src/+/15e8fb8c185a6137e42c895401c1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/15e8fb8c185a6137e42c895401c1... |