Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2835303002: [reland] Use TaskScheduler instead of blocking pool in file_downloader.cc. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
asanka
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[reland] Use TaskScheduler instead of blocking pool in file_downloader.cc. [The CL seems to have been reverted because of flakes when the first patch set was sent to the CQ dry run. These flakes were fixed in the second patch set (the one that landed).] The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Original-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5 Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467641} Committed: https://chromium.googlesource.com/chromium/src/+/15e8fb8c185a6137e42c895401c127972249d26f

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M chrome/browser/net/file_downloader.cc View 3 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/net/file_downloader_unittest.cc View 1 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 30 (19 generated)
fdoray
3 years, 8 months ago (2017-04-24 19:38:49 UTC) #1
fdoray
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used ...
3 years, 8 months ago (2017-04-24 19:38:52 UTC) #3
asanka
lgtm
3 years, 8 months ago (2017-04-26 03:10:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835303002/1
3 years, 8 months ago (2017-04-26 13:12:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/439401)
3 years, 8 months ago (2017-04-26 13:39:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835303002/20001
3 years, 8 months ago (2017-04-26 17:27:17 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5
3 years, 8 months ago (2017-04-26 18:51:55 UTC) #19
vitaliii
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2847553004/ by vitaliii@chromium.org. ...
3 years, 7 months ago (2017-04-27 11:32:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835303002/20001
3 years, 7 months ago (2017-04-27 12:05:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835303002/20001
3 years, 7 months ago (2017-04-27 12:07:28 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 12:10:54 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15e8fb8c185a6137e42c895401c1...

Powered by Google App Engine
This is Rietveld 408576698