Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2847533005: Remove references to debian wheezy sysroot (Closed)

Created:
3 years, 7 months ago by Sam Clegg
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to debian wheezy sysroot BUG=697494 Review-Url: https://codereview.chromium.org/2847533005 Cr-Commit-Position: refs/heads/master@{#470634} Committed: https://chromium.googlesource.com/chromium/src/+/3b9661305b564c476e9259c25f5a16ab45d5f734

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -36 lines) Patch
M docs/clang_tidy.md View 1 1 chunk +0 lines, -11 lines 0 comments Download
M infra/scripts/legacy/scripts/slave/chromium/sizes.py View 1 chunk +3 lines, -9 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 1 chunk +6 lines, -11 lines 0 comments Download
M tools/copyright_scanner/copyright_scanner.py View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
Sam Clegg
3 years, 7 months ago (2017-05-01 17:28:23 UTC) #10
Nico
lgtm, thanks https://codereview.chromium.org/2847533005/diff/1/docs/clang_tidy.md File docs/clang_tidy.md (right): https://codereview.chromium.org/2847533005/diff/1/docs/clang_tidy.md#newcode103 docs/clang_tidy.md:103: up-to-date, this shouldn't be needed. I think ...
3 years, 7 months ago (2017-05-01 17:37:55 UTC) #11
Tom Anderson
lgtm
3 years, 7 months ago (2017-05-01 17:41:24 UTC) #12
Sam Clegg
https://codereview.chromium.org/2847533005/diff/1/docs/clang_tidy.md File docs/clang_tidy.md (right): https://codereview.chromium.org/2847533005/diff/1/docs/clang_tidy.md#newcode103 docs/clang_tidy.md:103: up-to-date, this shouldn't be needed. On 2017/05/01 17:37:55, Nico ...
3 years, 7 months ago (2017-05-01 18:53:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847533005/20001
3 years, 7 months ago (2017-05-01 18:54:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/424527)
3 years, 7 months ago (2017-05-01 19:04:37 UTC) #18
Sam Clegg
3 years, 7 months ago (2017-05-02 16:40:56 UTC) #20
Paweł Hajdan Jr.
LGTM
3 years, 7 months ago (2017-05-05 17:30:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847533005/20001
3 years, 7 months ago (2017-05-10 15:20:38 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 17:45:17 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b9661305b564c476e9259c25f5a...

Powered by Google App Engine
This is Rietveld 408576698