docs/clang_tidy.md - Issue 2847533005: Remove references to debian wheezy sysroot

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: docs/clang_tidy.md

Issue 2847533005: Remove references to debian wheezy sysroot (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Clang Tidy	1 # Clang Tidy

2	2

3 [TOC]	3 [TOC]

4	4

5 ## Danger, Will Robinson!	5 ## Danger, Will Robinson!

6	6

7 Support for `clang-tidy` in Chromium is very experimental, and is somewhat	7 Support for `clang-tidy` in Chromium is very experimental, and is somewhat

8 painful to use. We are exploring making it easier and integrating with existing	8 painful to use. We are exploring making it easier and integrating with existing

9 tools, but aren't there yet. If you don't want to wait and enjoy tinkering,	9 tools, but aren't there yet. If you don't want to wait and enjoy tinkering,

10 forge ahead. Otherwise, feel free to turn back now.	10 forge ahead. Otherwise, feel free to turn back now.

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 ```	88 ```

89	89

90 \*It's not clear which, if any, `gn` flags may cause issues for `clang-tidy`.	90 \*It's not clear which, if any, `gn` flags may cause issues for `clang-tidy`.

91 I've had no problems building a component release build, both with and without	91 I've had no problems building a component release build, both with and without

92 goma. if you run into issues, let us know!	92 goma. if you run into issues, let us know!

93	93

94 ## Troubleshooting	94 ## Troubleshooting

95	95

96 If you see errors like	96 If you see errors like

97 ```	97 ```

98 src/build/linux/debian_wheezy_amd64-sysroot/usr/include/wchar.h:40:11: error: 's tdarg.h' file not found [clang-diagnostic-error]	98 src/build/linux/debian_jessie_amd64-sysroot/usr/include/wchar.h:40:11: error: 's tdarg.h' file not found [clang-diagnostic-error]

99 ```	99 ```

100	100

101 then you should also build the `clang-headers` target in your llvm checkout.	101 then you should also build the `clang-headers` target in your llvm checkout.

102 This is fixed by http://reviews.llvm.org/D22046, so if your llvm checkout is	102 This is fixed by http://reviews.llvm.org/D22046, so if your llvm checkout is

103 up-to-date, this shouldn't be needed.	103 up-to-date, this shouldn't be needed.
	Nico 2017/05/01 17:37:55 I think you can remove the whole "Troubleshooting" I think you can remove the whole "Troubleshooting" section, r274751 landed ten months ago by now. Sam Clegg 2017/05/01 18:53:35 Done Show quoted text On 2017/05/01 17:37:55, Nico wrote: > I think you can remove the whole "Troubleshooting" section, r274751 landed ten > months ago by now. Done
104	104

105 ## Questions	105 ## Questions

106	106

107 Questions? Reach out to rdevlin.cronin@chromium.org or thakis@chromium.org.	107 Questions? Reach out to rdevlin.cronin@chromium.org or thakis@chromium.org.

108 Discoveries? Update the doc!	108 Discoveries? Update the doc!

OLD	NEW

« no previous file with comments | « no previous file | infra/scripts/legacy/scripts/slave/chromium/sizes.py » ('j') | tools/checklicenses/checklicenses.py » ('J')