Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2847463002: Comment out the single use of v8::ValueSerializer::GetCurrentDataFormatVersion while it changes. (Closed)

Created:
3 years, 7 months ago by jbroman
Modified:
3 years, 7 months ago
Reviewers:
pwnall
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Comment out the single use of v8::ValueSerializer::GetCurrentDataFormatVersion while it changes. This is becoming a compile-time constant, and its name is changing in that process. I'll restore this (non-critical) assertion once that change has stuck. R=pwnall@chromium.org BUG=704293 Review-Url: https://codereview.chromium.org/2847463002 Cr-Commit-Position: refs/heads/master@{#467418} Committed: https://chromium.googlesource.com/chromium/src/+/cd28a17e10afc0914d2784718df63e9ce3626076

Patch Set 1 #

Patch Set 2 : unused constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jbroman
3 years, 7 months ago (2017-04-26 18:02:44 UTC) #3
pwnall
lgtm
3 years, 7 months ago (2017-04-26 19:24:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847463002/20001
3 years, 7 months ago (2017-04-26 19:34:50 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 19:49:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cd28a17e10afc0914d2784718df6...

Powered by Google App Engine
This is Rietveld 408576698