Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp

Issue 2847463002: Comment out the single use of v8::ValueSerializer::GetCurrentDataFormatVersion while it changes. (Closed)
Patch Set: unused constant Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
index c2979fc3b1f6c348f200573b4358190dc9ba912e..3eee75d5ce8514138c3d03ab0d064e8bce7647e1 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
@@ -135,7 +135,7 @@ void CheckKeyPathNumberValue(v8::Isolate* isolate,
constexpr static size_t kSSVHeaderBlinkVersionTagOffset = 0;
constexpr static size_t kSSVHeaderBlinkVersionOffset = 1;
constexpr static size_t kSSVHeaderV8VersionTagOffset = 2;
-constexpr static size_t kSSVHeaderV8VersionOffset = 3;
+// constexpr static size_t kSSVHeaderV8VersionOffset = 3;
// Follows the same steps as the IndexedDB value serialization code.
void SerializeV8Value(v8::Local<v8::Value> value,
@@ -165,8 +165,9 @@ void SerializeV8Value(v8::Local<v8::Value> value,
ASSERT_EQ(static_cast<unsigned char>(kVersionTag),
wire_data[kSSVHeaderV8VersionTagOffset]);
- ASSERT_EQ(v8::ValueSerializer::GetCurrentDataFormatVersion(),
- wire_data[kSSVHeaderV8VersionOffset]);
+ // TODO(jbroman): Use the compile-time constant for V8 data format version.
+ // ASSERT_EQ(v8::ValueSerializer::GetCurrentDataFormatVersion(),
+ // wire_data[kSSVHeaderV8VersionOffset]);
}
PassRefPtr<IDBValue> CreateIDBValue(v8::Isolate* isolate,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698