Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2847433002: Gracefully handle failed Mojo calls in the NotificationManager (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
awdf, elawrence
CC:
chromium-reviews, haraken, blink-reviews, Peter Beverloo, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gracefully handle failed Mojo calls in the NotificationManager This continues to be an unexpected failure so we keep the DCHECK, but now with a predefined return value to handle this. BUG=713545 Review-Url: https://codereview.chromium.org/2847433002 Cr-Commit-Position: refs/heads/master@{#467396} Committed: https://chromium.googlesource.com/chromium/src/+/1fbce15166ac6fdbd967a1249375afdbd711de8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/notifications/NotificationManager.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Peter Beverloo
+elawrence PTAL
3 years, 8 months ago (2017-04-26 14:40:41 UTC) #4
elawrence
On 2017/04/26 14:40:41, Peter Beverloo wrote: > +elawrence PTAL LGTM.
3 years, 8 months ago (2017-04-26 14:58:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847433002/1
3 years, 8 months ago (2017-04-26 18:38:53 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 18:50:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1fbce15166ac6fdbd967a1249375...

Powered by Google App Engine
This is Rietveld 408576698