Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

Issue 2847433002: Gracefully handle failed Mojo calls in the NotificationManager (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp b/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
index fa84d724432bd15315ecd8fe2e3587dcc4ba2a7b..d5461976966a13bc46cae7b964cbcf3239e2e036 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
+++ b/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
@@ -53,9 +53,12 @@ mojom::blink::PermissionStatus NotificationManager::GetPermissionStatus(
}
mojom::blink::PermissionStatus permission_status;
- const bool result = notification_service_->GetPermissionStatus(
- execution_context->GetSecurityOrigin()->ToString(), &permission_status);
- DCHECK(result);
+ if (!notification_service_->GetPermissionStatus(
+ execution_context->GetSecurityOrigin()->ToString(),
+ &permission_status)) {
+ NOTREACHED();
+ return mojom::blink::PermissionStatus::DENIED;
+ }
return permission_status;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698