Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Issue 2847303002: Remove unnecessary zoom argument from GetImage() as its value is always available through the Layou… (Closed)

Created:
3 years, 7 months ago by jstenback
Modified:
3 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, haraken, blink-reviews-paint_chromium.org, dglazkov+blink, dshwang, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, blink-reviews-layout_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary zoom argument from GetImage() as its value is always available through the LayoutObject argument. (rebased) BUG=716203 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2847303002 Cr-Commit-Position: refs/heads/master@{#469560} Committed: https://chromium.googlesource.com/chromium/src/+/a11f72c868235d4673cd96c7eea24ad9e7eb4b55

Patch Set 1 #

Patch Set 2 : (rebased) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -69 lines) Patch
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintImageGenerator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintValue.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleInvalidImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Justin Novosad
lgtm
3 years, 7 months ago (2017-05-02 18:56:47 UTC) #8
Justin Novosad
lgtm
3 years, 7 months ago (2017-05-02 18:56:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847303002/1
3 years, 7 months ago (2017-05-04 21:24:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/262501)
3 years, 7 months ago (2017-05-04 21:29:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847303002/20001
3 years, 7 months ago (2017-05-04 23:15:42 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 01:09:27 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a11f72c868235d4673cd96c7eea2...

Powered by Google App Engine
This is Rietveld 408576698