Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h

Issue 2847303002: Remove unnecessary zoom argument from GetImage() as its value is always available through the Layou… (Closed)
Patch Set: (rebased) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CSSPaintImageGeneratorImpl_h 5 #ifndef CSSPaintImageGeneratorImpl_h
6 #define CSSPaintImageGeneratorImpl_h 6 #define CSSPaintImageGeneratorImpl_h
7 7
8 #include "core/css/CSSPaintImageGenerator.h" 8 #include "core/css/CSSPaintImageGenerator.h"
9 #include "core/css/cssom/CSSStyleValue.h" 9 #include "core/css/cssom/CSSStyleValue.h"
10 #include "platform/bindings/ScopedPersistent.h" 10 #include "platform/bindings/ScopedPersistent.h"
(...skipping 10 matching lines...) Expand all
21 21
22 class CSSPaintImageGeneratorImpl final : public CSSPaintImageGenerator { 22 class CSSPaintImageGeneratorImpl final : public CSSPaintImageGenerator {
23 public: 23 public:
24 static CSSPaintImageGenerator* Create(const String& name, 24 static CSSPaintImageGenerator* Create(const String& name,
25 Document&, 25 Document&,
26 Observer*); 26 Observer*);
27 ~CSSPaintImageGeneratorImpl() override; 27 ~CSSPaintImageGeneratorImpl() override;
28 28
29 PassRefPtr<Image> Paint(const LayoutObject&, 29 PassRefPtr<Image> Paint(const LayoutObject&,
30 const IntSize&, 30 const IntSize&,
31 float zoom,
32 const CSSStyleValueVector*) final; 31 const CSSStyleValueVector*) final;
33 const Vector<CSSPropertyID>& NativeInvalidationProperties() const final; 32 const Vector<CSSPropertyID>& NativeInvalidationProperties() const final;
34 const Vector<AtomicString>& CustomInvalidationProperties() const final; 33 const Vector<AtomicString>& CustomInvalidationProperties() const final;
35 bool HasAlpha() const final; 34 bool HasAlpha() const final;
36 const Vector<CSSSyntaxDescriptor>& InputArgumentTypes() const final; 35 const Vector<CSSSyntaxDescriptor>& InputArgumentTypes() const final;
37 bool IsImageGeneratorReady() const final; 36 bool IsImageGeneratorReady() const final;
38 37
39 // Should be called from the PaintWorkletGlobalScope when a javascript class 38 // Should be called from the PaintWorkletGlobalScope when a javascript class
40 // is registered with the same name. 39 // is registered with the same name.
41 void SetDefinition(CSSPaintDefinition*); 40 void SetDefinition(CSSPaintDefinition*);
42 41
43 DECLARE_VIRTUAL_TRACE(); 42 DECLARE_VIRTUAL_TRACE();
44 43
45 private: 44 private:
46 CSSPaintImageGeneratorImpl(Observer*); 45 CSSPaintImageGeneratorImpl(Observer*);
47 CSSPaintImageGeneratorImpl(CSSPaintDefinition*); 46 CSSPaintImageGeneratorImpl(CSSPaintDefinition*);
48 47
49 Member<CSSPaintDefinition> definition_; 48 Member<CSSPaintDefinition> definition_;
50 Member<Observer> observer_; 49 Member<Observer> observer_;
51 }; 50 };
52 51
53 } // namespace blink 52 } // namespace blink
54 53
55 #endif // CSSPaintImageGeneratorImpl_h 54 #endif // CSSPaintImageGeneratorImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698