Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 284723003: Remove const WebMediaPlayer::didLoadingProgress() implementations. (Closed)

Created:
6 years, 7 months ago by sandersd (OOO until July 31)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove const WebMediaPlayer::didLoadingProgress() implementations. This is the third of three changes; the others are: https://codereview.chromium.org/275303002 (chromium prep) https://codereview.chromium.org/272223004 (blink side) BUG=360251 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sandersd (OOO until July 31)
6 years, 7 months ago (2014-05-13 00:05:28 UTC) #1
scherkus (not reviewing)
lgtm
6 years, 7 months ago (2014-05-13 00:12:54 UTC) #2
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 7 months ago (2014-05-14 18:09:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/284723003/1
6 years, 7 months ago (2014-05-14 18:10:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 21:26:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 21:40:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/31529)
6 years, 7 months ago (2014-05-14 21:40:11 UTC) #7
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 7 months ago (2014-05-14 21:53:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/284723003/1
6 years, 7 months ago (2014-05-14 21:56:04 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 23:02:48 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 00:02:37 UTC) #11
Message was sent while issue was closed.
Change committed as 270520

Powered by Google App Engine
This is Rietveld 408576698