Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2847093002: Restore one millisecond minimum timeout for setTimeout. (Closed)

Created:
3 years, 7 months ago by hjd
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Restore one millisecond minimum timeout for setTimeout. This reverts the non-test part of https://codereview.chromium.org/2738773004/ but leaves most of the test changes in place since they should now work regardless of the setTimeout behaviour. BUG=711044 Review-Url: https://codereview.chromium.org/2853493002 Cr-Commit-Position: refs/heads/master@{#467962} (cherry picked from commit c41d3c785c5179a38e54c6c80ea63d56cc7cfd12) Review-Url: https://codereview.chromium.org/2847093002 . Cr-Commit-Position: refs/branch-heads/3071@{#291} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b16e680e6bb4f3bb2f4c44b1599a5e3d5603fa8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
hjd
3 years, 7 months ago (2017-04-28 12:24:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b16e680e6bb4f3bb2f4c44b1599a5e3d5603fa8a.

Powered by Google App Engine
This is Rietveld 408576698