Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2853493002: Restore one millisecond minimum timeout for setTimeout. (Closed)

Created:
3 years, 7 months ago by Dan Elphick
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org, Sami
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore one millisecond minimum timeout for setTimeout. This reverts the non-test part of https://codereview.chromium.org/2738773004/ but leaves most of the test changes in place since they should now work regardless of the setTimeout behaviour. BUG=711044 Review-Url: https://codereview.chromium.org/2853493002 Cr-Commit-Position: refs/heads/master@{#467962} Committed: https://chromium.googlesource.com/chromium/src/+/c41d3c785c5179a38e54c6c80ea63d56cc7cfd12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Dan Elphick
This is partial rollback (excluding test changes that will pass now regardless) needed to fix ...
3 years, 7 months ago (2017-04-28 09:37:55 UTC) #3
haraken
LGTM
3 years, 7 months ago (2017-04-28 09:50:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853493002/1
3 years, 7 months ago (2017-04-28 09:51:54 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 11:50:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c41d3c785c5179a38e54c6c80ea6...

Powered by Google App Engine
This is Rietveld 408576698