Parse update check run actions for the component updater.

Parse update check run actions for the component updater.

The action will be used in a future changelist, landing soon.

BUG=687231
Review-Url: https://codereview.chromium.org/2847023002
Cr-Commit-Position: refs/heads/master@{#468161}
Committed: https://chromium.googlesource.com/chromium/src/+/519656c643eeac268e2bb5f70074f9aabf2aefab

[Sorin Jianu, 2017-04-28 01:42:01]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 01:43:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:11:04]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Sorin Jianu, 2017-04-28 16:05:57]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org

[Sorin Jianu, 2017-04-28 16:05:57]

PTAL! TY!

[waffles, 2017-04-28 17:01:02]

lgtm

https://codereview.chromium.org/2847023002/diff/40001/components/update_clien...
File components/update_client/update_response.cc (right):

https://codereview.chromium.org/2847023002/diff/40001/components/update_clien...
components/update_client/update_response.cc:295: ParseActionsTag(updatecheck,
result);
Is there harm in moving these out of the ifs? (Always parse actions?)

[Sorin Jianu, 2017-04-28 17:03:01]

https://codereview.chromium.org/2847023002/diff/40001/components/update_clien...
File components/update_client/update_response.cc (right):

https://codereview.chromium.org/2847023002/diff/40001/components/update_clien...
components/update_client/update_response.cc:295: ParseActionsTag(updatecheck,
result);
On 2017/04/28 17:01:02, waffles wrote:
> Is there harm in moving these out of the ifs? (Always parse actions?)

There is no obvious harm but this way the code is obvious we are collecting
actions on these specific responses only.

[Sorin Jianu, 2017-04-28 17:13:03]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2017-04-28 17:13:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2017-04-28 18:03:53]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2017-04-28 18:03:54]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/2847023002/#ps60001
(title: "Added missing data file dependency.")

[commit-bot: I haz the power, 2017-04-28 18:04:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 19:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 19:43:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sorin Jianu, 2017-04-28 20:07:08]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2017-04-28 20:07:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:39:38]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493410028107600,
"parent_rev": "52cb55108113396c95ba08d9e40c0ba18f528de3", "commit_rev":
"519656c643eeac268e2bb5f70074f9aabf2aefab"}

[commit-bot: I haz the power, 2017-04-28 22:39:52]

Description was changed from

==========
Parse update check run actions for the component updater.

The action will be used in a future changelist, landing soon.

BUG=687231
==========

to

==========
Parse update check run actions for the component updater.

The action will be used in a future changelist, landing soon.

BUG=687231

Review-Url: https://codereview.chromium.org/2847023002
Cr-Commit-Position: refs/heads/master@{#468161}
Committed:
https://chromium.googlesource.com/chromium/src/+/519656c643eeac268e2bb5f70074...
==========

[commit-bot: I haz the power, 2017-04-28 22:39:53]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/519656c643eeac268e2bb5f70074...