Parse update check run actions for the component updater.

components/update_client/update_response.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/update_client/update_response.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
 
 #include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/version.h"
 #include "libxml/tree.h"
 #include "third_party/libxml/chromium/libxml_utils.h"
 
 namespace update_client {
 
 static const char* kExpectedResponseProtocol = "3.0";
 const char UpdateResponse::Result::kCohort[] = "cohort";
 const char UpdateResponse::Result::kCohortHint[] = "cohorthint";
 const char UpdateResponse::Result::kCohortName[] = "cohortname";
 
-UpdateResponse::UpdateResponse() {
-}
-UpdateResponse::~UpdateResponse() {
-}
+UpdateResponse::UpdateResponse() = default;
+UpdateResponse::~UpdateResponse() = default;
 
-UpdateResponse::Results::Results() : daystart_elapsed_seconds(kNoDaystart) {
-}
+UpdateResponse::Results::Results() = default;
 UpdateResponse::Results::Results(const Results& other) = default;
-UpdateResponse::Results::~Results() {
-}
+UpdateResponse::Results::~Results() = default;
 
-UpdateResponse::Result::Result() {}
+UpdateResponse::Result::Result() = default;
 UpdateResponse::Result::Result(const Result& other) = default;
-UpdateResponse::Result::~Result() {
-}
+UpdateResponse::Result::~Result() = default;
 
-UpdateResponse::Result::Manifest::Manifest() {
-}
+UpdateResponse::Result::Manifest::Manifest() = default;
 UpdateResponse::Result::Manifest::Manifest(const Manifest& other) = default;
-UpdateResponse::Result::Manifest::~Manifest() {
-}
+UpdateResponse::Result::Manifest::~Manifest() = default;
 
-UpdateResponse::Result::Manifest::Package::Package() : size(0), sizediff(0) {
-}
+UpdateResponse::Result::Manifest::Package::Package() = default;
 UpdateResponse::Result::Manifest::Package::Package(const Package& other) =
     default;
-UpdateResponse::Result::Manifest::Package::~Package() {
-}
+UpdateResponse::Result::Manifest::Package::~Package() = default;
 
 void UpdateResponse::ParseError(const char* details, ...) {
   va_list args;
   va_start(args, details);
 
   if (!errors_.empty()) {
     errors_ += "\r\n";
   }
 
   base::StringAppendV(&errors_, details, args);
@@ skipping 181 matching lines @@
 
   // Expect at least one url for full update.
   if (result->crx_urls.empty()) {
     *error = "Missing valid url for full update.";
     return false;
   }
 
   return true;
 }
 
+// Parses the <actions> tag. It picks up the "run" attribute of the first
+// "action" element in "actions".
+void ParseActionsTag(xmlNode* updatecheck, UpdateResponse::Result* result) {
+  std::vector<xmlNode*> actions = GetChildren(updatecheck, "actions");
+  if (actions.empty())
+    return;
+
+  std::vector<xmlNode*> action = GetChildren(actions.front(), "action");
+  if (action.empty())
+    return;
+
+  result->action_run = GetAttribute(action.front(), "run");
+}
+
 // Parses the <updatecheck> tag.
 bool ParseUpdateCheckTag(xmlNode* updatecheck,
                          UpdateResponse::Result* result,
                          std::string* error) {
   // Read the |status| attribute.
   result->status = GetAttribute(updatecheck, "status");
   if (result->status.empty()) {
     *error = "Missing status on updatecheck node";
     return false;
   }
 
-  if (result->status == "noupdate")
+  if (result->status == "noupdate") {
+    ParseActionsTag(updatecheck, result);
     return true;
+  }
 
   if (result->status == "ok") {
     std::vector<xmlNode*> urls = GetChildren(updatecheck, "urls");
     if (urls.empty()) {
       *error = "Missing urls on updatecheck.";
       return false;
     }
 
     if (!ParseUrlsTag(urls[0], result, error)) {
       return false;
     }
 
     std::vector<xmlNode*> manifests = GetChildren(updatecheck, "manifest");
     if (manifests.empty()) {
       *error = "Missing manifest on updatecheck.";
       return false;
     }
 
+    ParseActionsTag(updatecheck, result);

[waffles, 2017/04/28 17:01:02]

Is there harm in moving these out of the ifs? (Always parse actions?)

[Sorin Jianu, 2017/04/28 17:03:01]

There is no obvious harm but this way the code is obvious we are collecting
actions on these specific responses only.

     return ParseManifestTag(manifests[0], result, error);
   }
 
   // Return the |updatecheck| element status as a parsing error.
   *error = result->status;
   return false;
 }
 
 // Parses a single <app> tag.
 bool ParseAppTag(xmlNode* app,
@@ skipping 94 matching lines @@
       results_.list.push_back(result);
     } else {
       ParseError("%s", error.c_str());
     }
   }
 
   return true;
 }
 
 }  // namespace update_client