Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2846953002: Clean up descriptions and add metrics for the Data Saver UI (Closed)

Created:
3 years, 7 months ago by megjablon
Modified:
3 years, 7 months ago
Reviewers:
Theresa, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up descriptions and add metrics for the Data Saver UI Specifically, add menu option displays and track site breakdown displays, sorting, and expansion. BUG=716111 Review-Url: https://codereview.chromium.org/2846953002 Cr-Commit-Position: refs/heads/master@{#468107} Committed: https://chromium.googlesource.com/chromium/src/+/fd1f401a843ef214df3818fe714aa7303d27261d

Patch Set 1 #

Messages

Total messages: 14 (7 generated)
megjablon
twellington: chrome/* isherman: histograms.xml
3 years, 7 months ago (2017-04-27 18:41:03 UTC) #3
Ilya Sherman
Metrics lgtm
3 years, 7 months ago (2017-04-27 21:27:17 UTC) #4
Theresa
lgtm
3 years, 7 months ago (2017-04-27 23:12:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846953002/20001
3 years, 7 months ago (2017-04-28 17:23:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/372934)
3 years, 7 months ago (2017-04-28 18:54:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846953002/20001
3 years, 7 months ago (2017-04-28 19:31:34 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:14:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fd1f401a843ef214df3818fe714a...

Powered by Google App Engine
This is Rietveld 408576698