Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java

Issue 2846953002: Clean up descriptions and add metrics for the Data Saver UI (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java
index 1a72748c259933371712ecbb7075cee28a6e2ff1..8450c91e4fced05e1997bab2228d9f4ac7ea98e9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java
@@ -59,6 +59,8 @@ public class DataReductionSiteBreakdownView extends LinearLayout {
mDataUsedTitle.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View v) {
+ DataReductionProxyUma.dataReductionProxyUIAction(
+ DataReductionProxyUma.ACTION_SITE_BREAKDOWN_SORTED_BY_DATA_USED);
setTextViewUnsortedAttributes(mDataSavedTitle);
setTextViewSortedAttributes(mDataUsedTitle);
Collections.sort(mDataUseItems, new DataUsedComparator());
@@ -69,6 +71,8 @@ public class DataReductionSiteBreakdownView extends LinearLayout {
mDataSavedTitle.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View v) {
+ DataReductionProxyUma.dataReductionProxyUIAction(
+ DataReductionProxyUma.ACTION_SITE_BREAKDOWN_SORTED_BY_DATA_SAVED);
setTextViewUnsortedAttributes(mDataUsedTitle);
setTextViewSortedAttributes(mDataSavedTitle);
Collections.sort(mDataUseItems, new DataSavedComparator());
@@ -86,7 +90,14 @@ public class DataReductionSiteBreakdownView extends LinearLayout {
setTextViewUnsortedAttributes(mDataUsedTitle);
setTextViewSortedAttributes(mDataSavedTitle);
Collections.sort(items, new DataSavedComparator());
- updateSiteBreakdown();
+ if (mDataUseItems.size() == 0) {
+ setVisibility(GONE);
+ } else {
+ setVisibility(VISIBLE);
+ updateSiteBreakdown();
+ DataReductionProxyUma.dataReductionProxyUIAction(
+ DataReductionProxyUma.ACTION_SITE_BREAKDOWN_DISPLAYED);
+ }
}
private void setTextViewSortedAttributes(TextView textView) {
@@ -153,12 +164,6 @@ public class DataReductionSiteBreakdownView extends LinearLayout {
* Update the site breakdown to display the data use items.
*/
private void updateSiteBreakdown() {
- if (mDataUseItems.size() == 0) {
- setVisibility(GONE);
- return;
- }
-
- setVisibility(VISIBLE);
// Remove all old rows except the header.
mTableLayout.removeViews(1, mTableLayout.getChildCount() - 1);
@@ -211,6 +216,8 @@ public class DataReductionSiteBreakdownView extends LinearLayout {
row.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View v) {
+ DataReductionProxyUma.dataReductionProxyUIAction(
+ DataReductionProxyUma.ACTION_SITE_BREAKDOWN_EXPANDED);
mNumDataUseItemsToDisplay += NUM_DATA_USE_ITEMS_TO_ADD;
updateSiteBreakdown();
}

Powered by Google App Engine
This is Rietveld 408576698