Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2846923003:
Fix regression in page_cycler_v2.tough_layout_cases (Closed)
|
Created:
3 years, 7 months ago by rhogan Modified:
3 years, 7 months ago Reviewers:
eae CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix regression in page_cycler_v2.tough_layout_cases
Caused by https://codereview.chromium.org/2836293003. Instead detect
when margin has moved a float completely out of its former position
and mark any affected siblings for layout.
BUG=716385
Review-Url: https://codereview.chromium.org/2846923003
Cr-Commit-Position: refs/heads/master@{#468441}
Committed: https://chromium.googlesource.com/chromium/src/+/4a961b8eca27af4108358a30753197754316524b
Patch Set 1 #Patch Set 2 : bug 716385 #Patch Set 3 : bug 716385 #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
robhogan@gmail.com changed reviewers: + eae@chromium.org
Thanks for the quick fix! LGTM
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493655183207040,
"parent_rev": "5d2506ab023f35332c5a46417f8173f2439b7d90", "commit_rev":
"4a961b8eca27af4108358a30753197754316524b"}
Message was sent while issue was closed.
Description was changed from ========== Fix regression in page_cycler_v2.tough_layout_cases Caused by https://codereview.chromium.org/2836293003. Instead detect when margin has moved a float completely out of its former position and mark any affected siblings for layout. BUG=716385 ========== to ========== Fix regression in page_cycler_v2.tough_layout_cases Caused by https://codereview.chromium.org/2836293003. Instead detect when margin has moved a float completely out of its former position and mark any affected siblings for layout. BUG=716385 Review-Url: https://codereview.chromium.org/2846923003 Cr-Commit-Position: refs/heads/master@{#468441} Committed: https://chromium.googlesource.com/chromium/src/+/4a961b8eca27af4108358a307531... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4a961b8eca27af4108358a307531... |
