Let siblings layout if an adjacent float may no longer affect them

Let siblings layout if an adjacent float may no longer affect them

Negative margin top can move a float up out of the way of siblings/descendants
that are currently avoiding them. We need to account for the position of the child's
current lowest float so that it can try laying out again.

BUG=711938
Review-Url: https://codereview.chromium.org/2836293003
Cr-Commit-Position: refs/heads/master@{#467479}
Committed: https://chromium.googlesource.com/chromium/src/+/789b5e528fb3bd9ca44341de46547c45355652ab

[rhogan, 2017-04-25 17:54:26]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 17:54:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2017-04-25 17:55:22]

robhogan@gmail.com changed reviewers:
+ mstensho@opera.com

[rhogan, 2017-04-25 17:58:20]

Description was changed from

==========
Let siblings layout if an adjacent float may no longer affect them

BUG=711938
==========

to

==========
Let siblings layout if an adjacent float may no longer affect them

Negative margin top can move a float up out of the way of siblings/descendants
that are currently avoiding them. We need to note the position of the current
lowest float so that we can tell any siblings/floats that may have overlapped
to clear their float lists and try laying out again.

BUG=711938
==========

[rhogan, 2017-04-25 18:09:17]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[rhogan, 2017-04-25 19:06:22]

On 2017/04/25 at 17:55:23, rhogan wrote:
> 

Mm, unsurprisingly this approach has performance problems - increases one or two
of the float tests by up to 80%. I'll try something else.

[commit-bot: I haz the power, 2017-04-25 19:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:47:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rhogan, 2017-04-25 21:26:25]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 21:26:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:42:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2017-04-26 19:52:57]

Description was changed from

==========
Let siblings layout if an adjacent float may no longer affect them

Negative margin top can move a float up out of the way of siblings/descendants
that are currently avoiding them. We need to note the position of the current
lowest float so that we can tell any siblings/floats that may have overlapped
to clear their float lists and try laying out again.

BUG=711938
==========

to

==========
Let siblings layout if an adjacent float may no longer affect them

Negative margin top can move a float up out of the way of siblings/descendants
that are currently avoiding them. We need to account for the position of the
child's
current lowest float so that it can try laying out again.

BUG=711938
==========

[rhogan, 2017-04-26 20:01:29]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 20:02:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2017-04-26 20:09:08]

OK this is ready for a look now. No perf regressions anymore.

[commit-bot: I haz the power, 2017-04-26 21:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 21:29:39]

Dry run: This issue passed the CQ dry run.

[eae, 2017-04-26 21:33:10]

Very nice, LGTM!

[rhogan, 2017-04-26 22:04:30]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2017-04-26 22:05:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 22:12:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493244270535190,
"parent_rev": "e8efdf66b59ecc9747f49288969e648d1eafda5e", "commit_rev":
"789b5e528fb3bd9ca44341de46547c45355652ab"}

[commit-bot: I haz the power, 2017-04-26 22:12:18]

Description was changed from

==========
Let siblings layout if an adjacent float may no longer affect them

Negative margin top can move a float up out of the way of siblings/descendants
that are currently avoiding them. We need to account for the position of the
child's
current lowest float so that it can try laying out again.

BUG=711938
==========

to

==========
Let siblings layout if an adjacent float may no longer affect them

Negative margin top can move a float up out of the way of siblings/descendants
that are currently avoiding them. We need to account for the position of the
child's
current lowest float so that it can try laying out again.

BUG=711938

Review-Url: https://codereview.chromium.org/2836293003
Cr-Commit-Position: refs/heads/master@{#467479}
Committed:
https://chromium.googlesource.com/chromium/src/+/789b5e528fb3bd9ca44341de4654...
==========

[commit-bot: I haz the power, 2017-04-26 22:12:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/789b5e528fb3bd9ca44341de4654...