Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: components/page_info_strings.grdp

Issue 2846913002: Add a Certificate Viewer link to the Page Info dropdown (Closed)
Patch Set: Address nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_info_strings.grdp
diff --git a/components/page_info_strings.grdp b/components/page_info_strings.grdp
index f90b393d1c5d3f7d7708a4f02bb8e3fd710e6c24..959ab57f584e5b4387aa273723092c7e2df7cafe 100644
--- a/components/page_info_strings.grdp
+++ b/components/page_info_strings.grdp
@@ -1,5 +1,20 @@
<?xml version="1.0" encoding="utf-8"?>
<grit-part>
+
+ <!-- Certificate Viewer link -->
lgarron 2017/04/28 23:16:43 Nit: The strings in this file are in the order the
elawrence 2017/04/29 12:38:59 Done.
+ <message name="IDS_PAGE_INFO_CERTIFICATE" desc="Title of the certificate area in the Page Information Window, shown when a HTTPS site is loaded.">
lgarron 2017/04/28 23:16:43 Nit: Strings descriptions are standardized to "Pag
elawrence 2017/04/29 12:38:59 Done.
+ Certificate
+ </message>
+ <message name="IDS_PAGE_INFO_CERTIFICATE_VALID_LINK" desc="Text of the link that launches the Certificate Viewer. This appears in the Page Information Window when a HTTPS site is loaded with a valid certificate.">
lgarron 2017/04/28 23:16:43 Nit: I would reverse the description sentences to
elawrence 2017/04/29 12:38:59 Done.
+ Valid
+ </message>
+ <message name="IDS_PAGE_INFO_CERTIFICATE_INVALID_LINK" desc="Text of the link that launches the Certificate Viewer. This appears in the Page Information Window when a HTTPS site is loaded with an invalid certificate, e.g. https://wrong.host.badssl.com/.">
lgarron 2017/04/28 23:16:43 Same.
elawrence 2017/04/29 12:38:59 Done.
+ Invalid
+ </message>
+ <message name="IDS_PAGE_INFO_CERTIFICATE_VALID_LINK_TOOLTIP" desc="The text of the tooltip on IDS_PAGE_INFO_CERTIFICATE_VALID_LINK">
+ Issued by <ph name="ISSUER">$1<ex>Let's Encrypt X3</ex></ph>.
lgarron 2017/04/28 23:16:43 Nit: My instinct is that this string should not ha
elawrence 2017/04/29 12:38:59 Done. Terminal punctuation for Infotips which are
+ </message>
+
<!-- Summary strings -->
<message name="IDS_PAGEINFO_SECURE_SUMMARY" desc="A short summary phrase at the top of the Page Info bubble (which shows when you click the lock icon) that indicates that the connection to the current website is secure.">
Secure connection

Powered by Google App Engine
This is Rietveld 408576698