Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: components/page_info_strings.grdp

Issue 2846913002: Add a Certificate Viewer link to the Page Info dropdown (Closed)
Patch Set: Address nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <grit-part> 2 <grit-part>
3
4 <!-- Certificate Viewer link -->
lgarron 2017/04/28 23:16:43 Nit: The strings in this file are in the order the
elawrence 2017/04/29 12:38:59 Done.
5 <message name="IDS_PAGE_INFO_CERTIFICATE" desc="Title of the certificate area in the Page Information Window, shown when a HTTPS site is loaded.">
lgarron 2017/04/28 23:16:43 Nit: Strings descriptions are standardized to "Pag
elawrence 2017/04/29 12:38:59 Done.
6 Certificate
7 </message>
8 <message name="IDS_PAGE_INFO_CERTIFICATE_VALID_LINK" desc="Text of the link th at launches the Certificate Viewer. This appears in the Page Information Window when a HTTPS site is loaded with a valid certificate.">
lgarron 2017/04/28 23:16:43 Nit: I would reverse the description sentences to
elawrence 2017/04/29 12:38:59 Done.
9 Valid
10 </message>
11 <message name="IDS_PAGE_INFO_CERTIFICATE_INVALID_LINK" desc="Text of the link that launches the Certificate Viewer. This appears in the Page Information Windo w when a HTTPS site is loaded with an invalid certificate, e.g. https://wrong.ho st.badssl.com/.">
lgarron 2017/04/28 23:16:43 Same.
elawrence 2017/04/29 12:38:59 Done.
12 Invalid
13 </message>
14 <message name="IDS_PAGE_INFO_CERTIFICATE_VALID_LINK_TOOLTIP" desc="The text of the tooltip on IDS_PAGE_INFO_CERTIFICATE_VALID_LINK">
15 Issued by <ph name="ISSUER">$1<ex>Let's Encrypt X3</ex></ph>.
lgarron 2017/04/28 23:16:43 Nit: My instinct is that this string should not ha
elawrence 2017/04/29 12:38:59 Done. Terminal punctuation for Infotips which are
16 </message>
17
3 <!-- Summary strings --> 18 <!-- Summary strings -->
4 <message name="IDS_PAGEINFO_SECURE_SUMMARY" desc="A short summary phrase at th e top of the Page Info bubble (which shows when you click the lock icon) that in dicates that the connection to the current website is secure."> 19 <message name="IDS_PAGEINFO_SECURE_SUMMARY" desc="A short summary phrase at th e top of the Page Info bubble (which shows when you click the lock icon) that in dicates that the connection to the current website is secure.">
5 Secure connection 20 Secure connection
6 </message> 21 </message>
7 <message name="IDS_PAGEINFO_MIXED_CONTENT_SUMMARY" desc="A one-line summary at the top of the Page Info bubble (which shows when you click the security indica tor) if the connection to the current website is using mainly using a secure con nection but has some insecure parts (like insecurely loaded images)."> 22 <message name="IDS_PAGEINFO_MIXED_CONTENT_SUMMARY" desc="A one-line summary at the top of the Page Info bubble (which shows when you click the security indica tor) if the connection to the current website is using mainly using a secure con nection but has some insecure parts (like insecurely loaded images).">
8 Your connection to this site is not fully secure 23 Your connection to this site is not fully secure
9 </message> 24 </message>
10 <message name="IDS_PAGEINFO_NOT_SECURE_SUMMARY" desc="A one-line summary at th e top of the Page Info bubble (which shows when you click the security indicator ) if the connection to the current website is secure."> 25 <message name="IDS_PAGEINFO_NOT_SECURE_SUMMARY" desc="A one-line summary at th e top of the Page Info bubble (which shows when you click the security indicator ) if the connection to the current website is secure.">
11 Your connection to this site is not secure 26 Your connection to this site is not secure
12 </message> 27 </message>
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 <message name="IDS_PAGE_INFO_PERMISSION_BLOCKED_BY_EXTENSION" desc="The label used underneath a permission listed in the Page Info bubble if the permission wa s explicitly blocked by one of the user's extensions."> 143 <message name="IDS_PAGE_INFO_PERMISSION_BLOCKED_BY_EXTENSION" desc="The label used underneath a permission listed in the Page Info bubble if the permission wa s explicitly blocked by one of the user's extensions.">
129 Blocked by an extension 144 Blocked by an extension
130 </message> 145 </message>
131 <message name="IDS_PAGE_INFO_PERMISSION_ASK_BY_EXTENSION" desc="The label used underneath a permission listed in the Page Info bubble if the permission was ex plicitly set to 'Ask' by one of the user's extensions."> 146 <message name="IDS_PAGE_INFO_PERMISSION_ASK_BY_EXTENSION" desc="The label used underneath a permission listed in the Page Info bubble if the permission was ex plicitly set to 'Ask' by one of the user's extensions.">
132 Setting controlled by an extension 147 Setting controlled by an extension
133 </message> 148 </message>
134 <message name="IDS_PAGE_INFO_PERMISSION_AUTOMATICALLY_BLOCKED" desc="The label used underneath a permission listed in the Page Info bubble if the permission w as blocked by Chrome on behalf of the user."> 149 <message name="IDS_PAGE_INFO_PERMISSION_AUTOMATICALLY_BLOCKED" desc="The label used underneath a permission listed in the Page Info bubble if the permission w as blocked by Chrome on behalf of the user.">
135 Automatically blocked 150 Automatically blocked
136 </message> 151 </message>
137 </grit-part> 152 </grit-part>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698