Add a Certificate Viewer link to the Page Info dropdown

chrome/browser/ui/views/page_info/page_info_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAGE_INFO_PAGE_INFO_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PAGE_INFO_PAGE_INFO_BUBBLE_VIEW_H_
 
 #include <memory>
+#include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/ui/page_info/page_info_ui.h"
 #include "chrome/browser/ui/views/page_info/chosen_object_row_observer.h"
 #include "chrome/browser/ui/views/page_info/permission_selector_row.h"
 #include "chrome/browser/ui/views/page_info/permission_selector_row_observer.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "ui/views/bubble/bubble_dialog_delegate.h"
@@ skipping 111 matching lines @@
   // PageInfoUI implementations.
   void SetCookieInfo(const CookieInfoList& cookie_info_list) override;
   void SetPermissionInfo(const PermissionInfoList& permission_info_list,
                          ChosenObjectInfoList chosen_object_info_list) override;
   void SetIdentityInfo(const IdentityInfo& identity_info) override;
 
   // Creates the contents of the |site_settings_view_|. The ownership of the
   // returned view is transferred to the caller.
   views::View* CreateSiteSettingsView(int side_margin) WARN_UNUSED_RESULT;
 
+  // Creates a section containing a title, icon, and link. Used to display
+  // Cookies and Certificate information.
+  views::View* CreateInspectSection(const gfx::ImageSkia& image_icon,
+                                    const int title_id,
+                                    views::Link* link) WARN_UNUSED_RESULT;
+
   // Used to asynchronously handle clicks since these calls may cause the
   // destruction of the settings view and the base class window still needs to
   // be alive to finish handling the mouse or keyboard click.
   void HandleLinkClickedAsync(views::Link* source);
 
-  // Whether DevTools is disabled for the relevant profile.
-  bool is_devtools_disabled_;
-
   // The presenter that controls the Page Info UI.
   std::unique_ptr<PageInfo> presenter_;
 
   Profile* profile_;
 
   // The header section (containing security-related information).
   BubbleHeaderView* header_;
 
   // The security summary for the current page.
   base::string16 summary_text_;
 
   // The separator between the header and the site settings view.
   views::Separator* separator_;
 
-  // The view that contains the cookie and permissions sections.
+  // The view that contains the certificate, cookie, and permissions sections.

[lgarron, 2017/04/28 23:16:43]

That means "site settings" is no longer accurate, but I can't think of something
better.
Open to suggestions if you think of something.

[elawrence, 2017/04/29 12:38:58]

It arguably wasn't accurate before (cookies weren't a setting here) so I'll
leave this alone for now.

   views::View* site_settings_view_;
-  // The view that contains the contents of the "Cookies" part of the site
-  // settings view.
-  views::View* cookies_view_;
+
   // The link that opens the "Cookies" dialog.
   views::Link* cookie_dialog_link_;
+
   // The view that contains the "Permissions" table of the site settings view.
   views::View* permissions_view_;
 
   // The certificate provided by the site, if one exists.
   scoped_refptr<net::X509Certificate> certificate_;
 
   // These rows bundle together all the |View|s involved in a single row of the
   // permissions section, and keep those views updated when the underlying
   // |Permission| changes.
   std::vector<std::unique_ptr<PermissionSelectorRow>> selector_rows_;
 
   base::WeakPtrFactory<PageInfoBubbleView> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PageInfoBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAGE_INFO_PAGE_INFO_BUBBLE_VIEW_H_