Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2846913002: Add a Certificate Viewer link to the Page Info dropdown (Closed)
Patch Set: Address nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2553 matching lines...) Expand 10 before | Expand all | Expand 10 after
2564 {"lsd-permission-prompt", flag_descriptions::kLsdPermissionPromptName, 2564 {"lsd-permission-prompt", flag_descriptions::kLsdPermissionPromptName,
2565 flag_descriptions::kLsdPermissionPromptDescription, kOsAndroid, 2565 flag_descriptions::kLsdPermissionPromptDescription, kOsAndroid,
2566 FEATURE_VALUE_TYPE(features::kLsdPermissionPrompt)}, 2566 FEATURE_VALUE_TYPE(features::kLsdPermissionPrompt)},
2567 #endif 2567 #endif
2568 2568
2569 #if defined(OS_CHROMEOS) 2569 #if defined(OS_CHROMEOS)
2570 {"enable-touchscreen-calibration", 2570 {"enable-touchscreen-calibration",
2571 flag_descriptions::kTouchscreenCalibrationName, 2571 flag_descriptions::kTouchscreenCalibrationName,
2572 flag_descriptions::kTouchscreenCalibrationDescription, kOsCrOS, 2572 flag_descriptions::kTouchscreenCalibrationDescription, kOsCrOS,
2573 SINGLE_VALUE_TYPE(chromeos::switches::kEnableTouchCalibrationSetting)}, 2573 SINGLE_VALUE_TYPE(chromeos::switches::kEnableTouchCalibrationSetting)},
2574 #endif // defined(OS_CHROMEOS) 2574 #endif // defined(OS_CHROMEOS)
lgarron 2017/04/28 23:16:43 Nit: Still unrelated. (Same below.)
elawrence 2017/04/29 12:38:58 I've malformed this again.
2575 2575
2576 #if defined(OS_WIN) 2576 #if defined(OS_WIN)
2577 {"gdi-text-printing", flag_descriptions::kGdiTextPrinting, 2577 {"gdi-text-printing", flag_descriptions::kGdiTextPrinting,
2578 flag_descriptions::kGdiTextPrintingDescription, kOsWin, 2578 flag_descriptions::kGdiTextPrintingDescription, kOsWin,
2579 FEATURE_VALUE_TYPE(features::kGdiTextPrinting)}, 2579 FEATURE_VALUE_TYPE(features::kGdiTextPrinting)},
2580 {"postscript-printing", flag_descriptions::kPostscriptPrinting, 2580 {"postscript-printing", flag_descriptions::kPostscriptPrinting,
2581 flag_descriptions::kPostscriptPrintingDescription, kOsWin, 2581 flag_descriptions::kPostscriptPrintingDescription, kOsWin,
2582 FEATURE_VALUE_TYPE(features::kPostScriptPrinting)}, 2582 FEATURE_VALUE_TYPE(features::kPostScriptPrinting)},
2583 #endif // defined(OS_WIN) 2583 #endif // defined(OS_WIN)
2584 2584
2585 #if defined(OS_CHROMEOS) 2585 #if defined(OS_CHROMEOS)
2586 {"show-arc-files-app", flag_descriptions::kShowArcFilesAppName, 2586 {"show-arc-files-app", flag_descriptions::kShowArcFilesAppName,
2587 flag_descriptions::kShowArcFilesAppDescription, kOsCrOS, 2587 flag_descriptions::kShowArcFilesAppDescription, kOsCrOS,
2588 FEATURE_VALUE_TYPE(arc::kShowArcFilesAppFeature)}, 2588 FEATURE_VALUE_TYPE(arc::kShowArcFilesAppFeature)},
2589 #endif // defined(OS_CHROMEOS) 2589 #endif // defined(OS_CHROMEOS)
2590 2590
2591 #if defined(OS_CHROMEOS) 2591 #if defined(OS_CHROMEOS)
2592 {"force-enable-stylus-tools", 2592 {"force-enable-stylus-tools",
2593 flag_descriptions::kForceEnableStylusToolsName, 2593 flag_descriptions::kForceEnableStylusToolsName,
2594 flag_descriptions::kForceEnableStylusToolsDescription, kOsCrOS, 2594 flag_descriptions::kForceEnableStylusToolsDescription, kOsCrOS,
2595 SINGLE_VALUE_TYPE(ash::switches::kAshForceEnablePalette)}, 2595 SINGLE_VALUE_TYPE(ash::switches::kAshForceEnablePalette)},
2596 #endif // defined(OS_CHROMEOS) 2596 #endif // defined(OS_CHROMEOS)
2597 2597
2598 {"enable-midi-manager-dynamic-instantiation", 2598 {"enable-midi-manager-dynamic-instantiation",
2599 flag_descriptions::kEnableMidiManagerDynamicInstantiationName, 2599 flag_descriptions::kEnableMidiManagerDynamicInstantiationName,
2600 flag_descriptions::kEnableMidiManagerDynamicInstantiationDescription, 2600 flag_descriptions::kEnableMidiManagerDynamicInstantiationDescription,
2601 kOsAll, 2601 kOsAll,
2602 FEATURE_VALUE_TYPE(midi::features::kMidiManagerDynamicInstantiation)}, 2602 FEATURE_VALUE_TYPE(midi::features::kMidiManagerDynamicInstantiation)},
2603 2603
2604 #if defined(OS_WIN) 2604 #if defined(OS_WIN)
2605 {"new-usb-backend", flag_descriptions::kNewUsbBackendName, 2605 {"new-usb-backend", flag_descriptions::kNewUsbBackendName,
2606 flag_descriptions::kNewUsbBackendDescription, kOsWin, 2606 flag_descriptions::kNewUsbBackendDescription, kOsWin,
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
2758 {"enable-clipboard-provider", 2758 {"enable-clipboard-provider",
2759 flag_descriptions::kEnableOmniboxClipboardProviderName, 2759 flag_descriptions::kEnableOmniboxClipboardProviderName,
2760 flag_descriptions::kEnableOmniboxClipboardProviderDescription, kOsAndroid, 2760 flag_descriptions::kEnableOmniboxClipboardProviderDescription, kOsAndroid,
2761 FEATURE_VALUE_TYPE(omnibox::kEnableClipboardProvider)}, 2761 FEATURE_VALUE_TYPE(omnibox::kEnableClipboardProvider)},
2762 #endif 2762 #endif
2763 2763
2764 {"autoplay-policy", flag_descriptions::kAutoplayPolicyName, 2764 {"autoplay-policy", flag_descriptions::kAutoplayPolicyName,
2765 flag_descriptions::kAutoplayPolicyDescription, kOsAll, 2765 flag_descriptions::kAutoplayPolicyDescription, kOsAll,
2766 MULTI_VALUE_TYPE(kAutoplayPolicyChoices)}, 2766 MULTI_VALUE_TYPE(kAutoplayPolicyChoices)},
2767 2767
2768 #if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS))
2769 {"show-cert-link", flag_descriptions::kShowCertLinkOnPageInfoName,
2770 flag_descriptions::kShowCertLinkOnPageInfoDescription, kOsDesktop,
2771 SINGLE_VALUE_TYPE(switches::kShowCertLink)},
2772 #endif
2773
2768 // NOTE: Adding new command-line switches requires adding corresponding 2774 // NOTE: Adding new command-line switches requires adding corresponding
2769 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2775 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2770 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2776 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2771 }; 2777 };
2772 2778
2773 class FlagsStateSingleton { 2779 class FlagsStateSingleton {
2774 public: 2780 public:
2775 FlagsStateSingleton() 2781 FlagsStateSingleton()
2776 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2782 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2777 ~FlagsStateSingleton() {} 2783 ~FlagsStateSingleton() {}
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
2983 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2989 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2984 2990
2985 const FeatureEntry* GetFeatureEntries(size_t* count) { 2991 const FeatureEntry* GetFeatureEntries(size_t* count) {
2986 *count = arraysize(kFeatureEntries); 2992 *count = arraysize(kFeatureEntries);
2987 return kFeatureEntries; 2993 return kFeatureEntries;
2988 } 2994 }
2989 2995
2990 } // namespace testing 2996 } // namespace testing
2991 2997
2992 } // namespace about_flags 2998 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698