Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6220)

Unified Diff: chrome/browser/ui/views/page_info/page_info_bubble_view.h

Issue 2846913002: Add a Certificate Viewer link to the Page Info dropdown (Closed)
Patch Set: Address nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/page_info/page_info_bubble_view.h
diff --git a/chrome/browser/ui/views/page_info/page_info_bubble_view.h b/chrome/browser/ui/views/page_info/page_info_bubble_view.h
index 2074631391521f1b2a98aff668943c32e256ac12..578a42ed74f3ac78b5e957ea37969db6408e52e6 100644
--- a/chrome/browser/ui/views/page_info/page_info_bubble_view.h
+++ b/chrome/browser/ui/views/page_info/page_info_bubble_view.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_UI_VIEWS_PAGE_INFO_PAGE_INFO_BUBBLE_VIEW_H_
#include <memory>
+#include <vector>
#include "base/compiler_specific.h"
#include "base/macros.h"
@@ -137,14 +138,17 @@ class PageInfoBubbleView : public content::WebContentsObserver,
// returned view is transferred to the caller.
views::View* CreateSiteSettingsView(int side_margin) WARN_UNUSED_RESULT;
+ // Creates a section containing a title, icon, and link. Used to display
+ // Cookies and Certificate information.
+ views::View* CreateInspectSection(const gfx::ImageSkia& image_icon,
+ const int title_id,
+ views::Link* link) WARN_UNUSED_RESULT;
+
// Used to asynchronously handle clicks since these calls may cause the
// destruction of the settings view and the base class window still needs to
// be alive to finish handling the mouse or keyboard click.
void HandleLinkClickedAsync(views::Link* source);
- // Whether DevTools is disabled for the relevant profile.
- bool is_devtools_disabled_;
-
// The presenter that controls the Page Info UI.
std::unique_ptr<PageInfo> presenter_;
@@ -159,13 +163,12 @@ class PageInfoBubbleView : public content::WebContentsObserver,
// The separator between the header and the site settings view.
views::Separator* separator_;
- // The view that contains the cookie and permissions sections.
+ // The view that contains the certificate, cookie, and permissions sections.
lgarron 2017/04/28 23:16:43 That means "site settings" is no longer accurate,
elawrence 2017/04/29 12:38:58 It arguably wasn't accurate before (cookies weren'
views::View* site_settings_view_;
- // The view that contains the contents of the "Cookies" part of the site
- // settings view.
- views::View* cookies_view_;
+
// The link that opens the "Cookies" dialog.
views::Link* cookie_dialog_link_;
+
// The view that contains the "Permissions" table of the site settings view.
views::View* permissions_view_;

Powered by Google App Engine
This is Rietveld 408576698