Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2846883004: Revert of Build browser tests on all gpu release bots (Closed)

Created:
3 years, 7 months ago by Dirk Pranke
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, phajdan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build browser tests on all gpu release bots (patchset #1 id:1 of https://codereview.chromium.org/2841833003/ ) Reason for revert: I don't think this CL is still needed after my fix for crbug.com/714976. Original issue's description: > Build browser tests on all gpu release bots > > Work-around as browser_tests are erroneously not rebuilt properly on > gpu bots. > > BUG=chromium:714976 > TBR=kbr@chromium.org,fjhenigman@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > NOTRY=true > > Review-Url: https://codereview.chromium.org/2841833003 > Cr-Commit-Position: refs/heads/master@{#467292} > Committed: https://chromium.googlesource.com/chromium/src/+/1d0ceecfb8153cce088d62bf28d9c94c6601de91 TBR=fjhenigman@chromium.org,kbr@chromium.org,hablich@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:714976 Review-Url: https://codereview.chromium.org/2846883004 Cr-Commit-Position: refs/heads/master@{#467921} Committed: https://chromium.googlesource.com/chromium/src/+/a5ab58152fbb8f93dc9653f4ecce0d467fe6bf78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -60 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 2 chunks +7 lines, -25 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 1 chunk +3 lines, -15 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 chunk +4 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Dirk Pranke
Created Revert of Build browser tests on all gpu release bots
3 years, 7 months ago (2017-04-27 17:13:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846883004/1
3 years, 7 months ago (2017-04-27 17:14:31 UTC) #3
Michael Achenbach
lgtm, thanks!
3 years, 7 months ago (2017-04-27 17:21:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/285344)
3 years, 7 months ago (2017-04-27 17:35:59 UTC) #6
Ken Russell (switch to Gerrit)
lgtm too
3 years, 7 months ago (2017-04-27 22:32:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846883004/1
3 years, 7 months ago (2017-04-28 06:48:08 UTC) #9
Michael Achenbach
Hit cq again. The failures all looked like goma hiccups.
3 years, 7 months ago (2017-04-28 06:50:47 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 07:14:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5ab58152fbb8f93dc9653f4ecce...

Powered by Google App Engine
This is Rietveld 408576698