Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(79)

Issue 2841833003: Build browser tests on all gpu release bots (Closed)

Created:
2 years, 1 month ago by Michael Achenbach
Modified:
2 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, phajdan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Build browser tests on all gpu release bots Work-around as browser_tests are erroneously not rebuilt properly on gpu bots. BUG=chromium:714976 TBR=kbr@chromium.org,fjhenigman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2841833003 Cr-Commit-Position: refs/heads/master@{#467292} Committed: https://chromium.googlesource.com/chromium/src/+/1d0ceecfb8153cce088d62bf28d9c94c6601de91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -14 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 2 chunks +25 lines, -7 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 1 chunk +15 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 chunk +20 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Michael Achenbach
PTAL
2 years, 1 month ago (2017-04-26 09:23:38 UTC) #3
Paweł Hajdan Jr.
LGTM as a workaround.
2 years, 1 month ago (2017-04-26 09:58:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841833003/1
2 years, 1 month ago (2017-04-26 09:59:19 UTC) #11
Michael Hablich
lgtm
2 years, 1 month ago (2017-04-26 10:18:18 UTC) #12
Michael Achenbach
All tryjobs green except android, which has a dumb flake. Setting NOTRY now to speed ...
2 years, 1 month ago (2017-04-26 10:43:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841833003/1
2 years, 1 month ago (2017-04-26 10:43:36 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1d0ceecfb8153cce088d62bf28d9c94c6601de91
2 years, 1 month ago (2017-04-26 10:48:05 UTC) #20
Dirk Pranke
2 years, 1 month ago (2017-04-27 17:13:52 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2846883004/ by dpranke@chromium.org.

The reason for reverting is: I don't think this CL is still needed after my fix
for crbug.com/714976..

Powered by Google App Engine
This is Rietveld 408576698