MD Settings: Network and bluetooth polish

MD Settings: Network and bluetooth polish

This CL:
* Fixes button spacing in the network details page.
* Fixes the on/off toggle button font and color for network and
  bluetooth 
* Replaces incorrect primary/secondary button classes in dialogs
  with action/cancel-button
* Corrects the blue color for action buttons as per UX
* Converts the "add network" section to list-frame / list-item
  to correct borders and spacing.

BUG=710258, 710259, 710261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846763003
Cr-Commit-Position: refs/heads/master@{#468164}
Committed: https://chromium.googlesource.com/chromium/src/+/d58d3252c4b935c9e3565d8afc394ec46c9644aa

[stevenjb, 2017-04-27 21:25:59]

Description was changed from

==========
MD Settings: Network and bluetooth polish

BUG=710258,710259,710261
==========

to

==========
MD Settings: Network and bluetooth polish

BUG=710258,710259,710261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-27 21:34:03]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org, michaelpg@chromium.org

[stevenjb, 2017-04-27 21:34:05]

Whichever of you has a moment to review these minor changes (no rush).

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_page.html (right):

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_page.html:47: <div
class="list-frame vertical-list">
Stupid diff. This was added.

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_page.html:50: <div
actionable class="list-item" on-tap="onAddWiFiTap_">
class="settings-box continuation center" -> "list-item"

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_page.html:51: <div
class="start">$i18n{internetAddWiFi}</div>
"add-no-icon" removed (none of these have icons now and "list-item" includes
indentation).

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_page.html:57: <div
actionable class="list-item" on-tap="onAddVPNTap_">
class="settings-box continuation center" -> "list-item"

[dschuyler, 2017-04-27 21:52:16]

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
(right):

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html:31:
#onoff {
Can this be onOff or on-off

[stevenjb, 2017-04-28 16:23:15]

Description was changed from

==========
MD Settings: Network and bluetooth polish

BUG=710258,710259,710261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Network and bluetooth polish

This CL:
* Fixes button spacing in the network details page.
* Fixes the on/off toggle button font and color for network and
  bluetooth 
* Replaces incorrect primary/secondary button classes in dialogs
  with action/cancel-button
* Corrects the blue color for action buttons as per UX
* Converts the "add network" section to list-frame / list-item
  to correct borders and spacing.

BUG=710258,710259,710261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-28 16:33:13]

Note: I made a few additional changes in order to fix the primary button color
(only used in network, bluetooth, and the people page) as per discussion with
bettes@ in crbug.com/710258.

PTAL

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
(right):

https://codereview.chromium.org/2846763003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html:31:
#onoff {
On 2017/04/27 21:52:16, dschuyler wrote:
> Can this be onOff or on-off

Done.

[dschuyler, 2017-04-28 19:26:19]

lgtm

https://codereview.chromium.org/2846763003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_page.html (right):

https://codereview.chromium.org/2846763003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_page.html:66: <div
class="start">
Maybe: I'm not 100% sure, but this div may not be needed.

[stevenjb, 2017-04-28 19:49:36]

https://codereview.chromium.org/2846763003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_page.html (right):

https://codereview.chromium.org/2846763003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_page.html:66: <div
class="start">
On 2017/04/28 19:26:19, dschuyler wrote:
> Maybe: I'm not 100% sure, but this div may not be needed.

Hmm, actually, this really should have a button also. I added that instead.
PTAL.

[stevenjb, 2017-04-28 19:49:42]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 19:51:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 21:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:28:57]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-04-28 22:32:10]

lgtm

https://codereview.chromium.org/2846763003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_page.html (right):

https://codereview.chromium.org/2846763003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_page.html:66: <div
class="start">
On 2017/04/28 19:49:36, stevenjb wrote:
> On 2017/04/28 19:26:19, dschuyler wrote:
> > Maybe: I'm not 100% sure, but this div may not be needed.
> 
> Hmm, actually, this really should have a button also. I added that instead.
> PTAL.

Acknowledged.

[stevenjb, 2017-04-28 22:33:20]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:34:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:42:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493418800526390,
"parent_rev": "6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb", "commit_rev":
"d58d3252c4b935c9e3565d8afc394ec46c9644aa"}

[commit-bot: I haz the power, 2017-04-28 22:42:17]

Description was changed from

==========
MD Settings: Network and bluetooth polish

This CL:
* Fixes button spacing in the network details page.
* Fixes the on/off toggle button font and color for network and
  bluetooth 
* Replaces incorrect primary/secondary button classes in dialogs
  with action/cancel-button
* Corrects the blue color for action buttons as per UX
* Converts the "add network" section to list-frame / list-item
  to correct borders and spacing.

BUG=710258,710259,710261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Network and bluetooth polish

This CL:
* Fixes button spacing in the network details page.
* Fixes the on/off toggle button font and color for network and
  bluetooth 
* Replaces incorrect primary/secondary button classes in dialogs
  with action/cancel-button
* Corrects the blue color for action buttons as per UX
* Converts the "add network" section to list-frame / list-item
  to correct borders and spacing.

BUG=710258,710259,710261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846763003
Cr-Commit-Position: refs/heads/master@{#468164}
Committed:
https://chromium.googlesource.com/chromium/src/+/d58d3252c4b935c9e3565d8afc39...
==========

[commit-bot: I haz the power, 2017-04-28 22:42:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d58d3252c4b935c9e3565d8afc39...