Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_page.html

Issue 2846763003: MD Settings: Network and bluetooth polish (Closed)
Patch Set: Add button for third party vpn Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_page.html
diff --git a/chrome/browser/resources/settings/internet_page/internet_page.html b/chrome/browser/resources/settings/internet_page/internet_page.html
index 66a73ddb8cda68fa4b978d8a3fc5ba99be371397..6dc72c3e5e3316eed734f9b127052cea869ddb60 100644
--- a/chrome/browser/resources/settings/internet_page/internet_page.html
+++ b/chrome/browser/resources/settings/internet_page/internet_page.html
@@ -19,10 +19,6 @@
<dom-module id="settings-internet-page">
<template>
<style include="settings-shared">
- div.add-no-icon {
- -webkit-margin-start: 36px
- }
-
iron-icon {
-webkit-margin-end: 12px;
-webkit-margin-start: 4px;
@@ -48,30 +44,32 @@
</cr-expand-button>
</div>
<template is="dom-if" if="[[addConnectionExpanded_]]">
- <template is="dom-if" if="[[deviceIsEnabled_(deviceStates.WiFi)]]">
- <div actionable class="settings-box continuation center"
- on-tap="onAddWiFiTap_">
- <div class="start add-no-icon">$i18n{internetAddWiFi}</div>
+ <div class="list-frame vertical-list">
+ <template is="dom-if"
+ if="[[deviceIsEnabled_(deviceStates.WiFi)]]">
+ <div actionable class="list-item" on-tap="onAddWiFiTap_">
+ <div class="start">$i18n{internetAddWiFi}</div>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label="$i18n{internetAddWiFi}">
+ </button>
+ </div>
+ </template>
+ <div actionable class="list-item" on-tap="onAddVPNTap_">
+ <div class="start">$i18n{internetAddVPN}</div>
<button class="icon-external" is="paper-icon-button-light"
- aria-label="$i18n{internetAddWiFi}">
+ aria-label="$i18n{internetAddVPN}">
</button>
</div>
- </template>
- <div actionable class="settings-box continuation center"
- on-tap="onAddVPNTap_">
- <div class="start add-no-icon">$i18n{internetAddVPN}</div>
- <button class="icon-external" is="paper-icon-button-light"
- aria-label="$i18n{internetAddVPN}">
- </button>
- </div>
- <template is="dom-repeat" items="[[thirdPartyVpnProviders_]]">
- <div actionable class="settings-box continuation center"
- on-tap="onAddThirdPartyVpnTap_" provider="[[item]]">
- <div class="start add-no-icon">
- [[getAddThirdParrtyVpnLabel_(item)]]
+ <template is="dom-repeat" items="[[thirdPartyVpnProviders_]]">
+ <div actionable class="list-item"
+ on-tap="onAddThirdPartyVpnTap_" provider="[[item]]">
+ <div class="start">[[getAddThirdParrtyVpnLabel_(item)]]</div>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label$="[[getAddThirdParrtyVpnLabel_(item)]]">
+ </button>
</div>
- </div>
- </template>
+ </template>
+ </div>
</template>
</template>
<template is="dom-if" if="[[!allowAddConnection_(globalPolicy_)]]">

Powered by Google App Engine
This is Rietveld 408576698