Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2846743002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2846743002 Cr-Commit-Position: refs/heads/master@{#467756} Committed: https://chromium.googlesource.com/chromium/src/+/a0935db60204c9dc771d3322be8129b276a8172a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M extensions/browser/blob_holder.cc View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_content_script_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/view_type_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/renderer/api_binding_hooks.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/native_extension_bindings_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_web_contents_observer.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-27 04:04:13 UTC) #4
Reilly Grant (use Gerrit)
lgtm
3 years, 7 months ago (2017-04-27 15:32:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846743002/1
3 years, 7 months ago (2017-04-27 17:56:51 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:38:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0935db60204c9dc771d3322be81...

Powered by Google App Engine
This is Rietveld 408576698