extensions/renderer/native_extension_bindings_system.cc - Issue 2846743002: Switch SupportsUserData uses to use unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/native_extension_bindings_system.cc

Issue 2846743002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/native_extension_bindings_system.cc

diff --git a/extensions/renderer/native_extension_bindings_system.cc b/extensions/renderer/native_extension_bindings_system.cc

index f4d5d5c85879f255a0872490b569ae31e1454b9c..db0f0542a8347e6750679df68b88dae33f04cc3a 100644

--- a/extensions/renderer/native_extension_bindings_system.cc

+++ b/extensions/renderer/native_extension_bindings_system.cc

@@ -370,7 +370,7 @@ void NativeExtensionBindingsSystem::DidCreateScriptContext(

DCHECK(!per_context_data->GetUserData(kBindingsSystemPerContextKey));

auto data = base::MakeUnique<BindingsSystemPerContextData>(

weak_factory_.GetWeakPtr());

- per_context_data->SetUserData(kBindingsSystemPerContextKey, data.release());

+ per_context_data->SetUserData(kBindingsSystemPerContextKey, std::move(data));

if (get_internal_api_.IsEmpty()) {

get_internal_api_.Set(