[Media] Added feature flag for new remote playback pipeline

[Media] Added feature flag for new remote playback pipeline

Added a feature and a chrome://flags entry to hide the new remote playback
pipeline behind it. Created a virtual test folder for the relevant
LayoutTests with the flag enabled.
Moved some of these tests to media/controls/ to avoid running all the media
tests twice.

BUG=517102
TEST=run the new virtual tests with the flag enabled

Review-Url: https://codereview.chromium.org/2846713002
Cr-Commit-Position: refs/heads/master@{#468224}
Committed: https://chromium.googlesource.com/chromium/src/+/232757946494489747c5752e32890f3819f2a658

[whywhat, 2017-04-27 00:33:12]

avayvod@chromium.org changed reviewers:
+ jam@chromium.org, mkwst@chromium.org

[whywhat, 2017-04-27 00:33:13]

PTaL

I realized that the refactoring I have in the works might actually break metrics
(and the feature) so I'd better have it behind the flag. This change introduces
the flag.
I'll rebase the first refactoring CL
(https://codereview.chromium.org/2782373002) on top of it tomorrow.

mkwst: content/public/common/common_param_traits_macros.h
jam: the rest

[whywhat, 2017-04-27 00:33:19]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 00:34:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 01:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:36:07]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Mike West, 2017-04-27 11:12:53]

https://codereview.chromium.org/2846713002/diff/1/content/public/common/commo...
File content/public/common/common_param_traits_macros.h (right):

https://codereview.chromium.org/2846713002/diff/1/content/public/common/commo...
content/public/common/common_param_traits_macros.h:251:
IPC_STRUCT_TRAITS_MEMBER(new_remote_playback_pipeline_enabled)
Rather than adding this to WebPreferences, did you consider turning it into a
feature (e.g. `content/public/common/content_features.h`?)

[whywhat, 2017-04-27 14:17:29]

https://codereview.chromium.org/2846713002/diff/1/content/public/common/commo...
File content/public/common/common_param_traits_macros.h (right):

https://codereview.chromium.org/2846713002/diff/1/content/public/common/commo...
content/public/common/common_param_traits_macros.h:251:
IPC_STRUCT_TRAITS_MEMBER(new_remote_playback_pipeline_enabled)
On 2017/04/27 at 11:12:53, Mike West wrote:
> Rather than adding this to WebPreferences, did you consider turning it into a
feature (e.g. `content/public/common/content_features.h`?)

Do you mean I could directly use
FeatureList::IsEnabled(media::kNewRemotePlaybackPipeline) ?

Didn't realize it was available there TBH.

[whywhat, 2017-04-27 14:32:18]

Removed WebPreferences change. Added histogram

[whywhat, 2017-04-27 14:32:41]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 14:33:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-04-27 15:30:13]

On 2017/04/27 00:33:13, whywhat wrote:
> PTaL
> 
> I realized that the refactoring I have in the works might actually break
metrics
> (and the feature) so I'd better have it behind the flag. This change
introduces
> the flag.
> I'll rebase the first refactoring CL
> (https://codereview.chromium.org/2782373002) on top of it tomorrow.
> 
> mkwst: content/public/common/common_param_traits_macros.h
> jam: the rest

I'm not an owner in webkit, so you'll need to get a reviewer for that. ditto for
histograms.
the other files lgtm

[whywhat, 2017-04-27 16:38:58]

avayvod@chromium.org changed reviewers:
+ isherman@chromium.org, mlamouri@chromium.org
- mkwst@chromium.org

[whywhat, 2017-04-27 16:38:59]

+mlamouri for webkit
+isherman for histograms.xml

[commit-bot: I haz the power, 2017-04-27 16:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:42:04]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ilya Sherman, 2017-04-27 19:50:31]

histograms.xml lgtm

[whywhat, 2017-04-27 21:36:34]

Rebaseline

[whywhat, 2017-04-27 21:37:08]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:37:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 22:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:35:06]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mlamouri (slow - plz ping), 2017-04-28 10:49:44]

rs lgtm

[whywhat, 2017-04-28 15:36:50]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 15:37:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 17:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 17:41:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[whywhat, 2017-04-28 22:09:50]

Fixed failing layout tests

[whywhat, 2017-04-28 22:12:17]

Fixed failing layout tests

[whywhat, 2017-04-28 22:57:06]

Patchset #4 (id:60001) has been deleted

[whywhat, 2017-04-28 22:57:18]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 22:58:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 01:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 01:38:34]

Dry run: This issue passed the CQ dry run.

[whywhat, 2017-04-29 04:04:45]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2017-04-29 04:04:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
isherman@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2846713002/#ps80001
(title: "Fixed failing layout tests")

[commit-bot: I haz the power, 2017-04-29 04:05:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 04:12:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493438685351980,
"parent_rev": "77db41b769602da7ccc0106c285490f149fe343d", "commit_rev":
"232757946494489747c5752e32890f3819f2a658"}

[commit-bot: I haz the power, 2017-04-29 04:13:05]

Description was changed from

==========
[Media] Added feature flag for new remote playback pipeline

Added a feature and a chrome://flags entry to hide the new remote playback
pipeline behind it. Created a virtual test folder for the relevant
LayoutTests with the flag enabled.
Moved some of these tests to media/controls/ to avoid running all the media
tests twice.

BUG=517102
TEST=run the new virtual tests with the flag enabled
==========

to

==========
[Media] Added feature flag for new remote playback pipeline

Added a feature and a chrome://flags entry to hide the new remote playback
pipeline behind it. Created a virtual test folder for the relevant
LayoutTests with the flag enabled.
Moved some of these tests to media/controls/ to avoid running all the media
tests twice.

BUG=517102
TEST=run the new virtual tests with the flag enabled

Review-Url: https://codereview.chromium.org/2846713002
Cr-Commit-Position: refs/heads/master@{#468224}
Committed:
https://chromium.googlesource.com/chromium/src/+/232757946494489747c5752e3289...
==========

[commit-bot: I haz the power, 2017-04-29 04:13:07]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/232757946494489747c5752e3289...