third_party/WebKit/LayoutTests/media/video-overlay-cast-covering.html - Issue 2846713002: [Media] Added feature flag for new remote playback pipeline

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-overlay-cast-covering.html

Issue 2846713002: [Media] Added feature flag for new remote playback pipeline (Closed)

Patch Set: Fixed failing layout tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-with-cast-rendering.html ('k') | third_party/WebKit/LayoutTests/media/video-overlay-cast-dark-rendering.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!doctype html>

2 <html>

3 <head>

4 <title>Hiding the cast overlay button</title>

5 <script src="media-controls.js"></script>

6 <script src="../resources/testharness.js"></script>

7 <script src="../resources/testharnessreport.js"></script>

8 <style>

9 body { background-color: gray; }

10 .video-group { position: absolute; }

11 .video-group > * { position: absolute; top: 0; }

12 .overlay {border: solid 1px; height: 50px; width: 80px; }

13 .video { width: 320px; height: 240px; background-color: white; }

14 .test-error { position: absolute; top: 250px; }

15 #v2 { top: 300px; }

16 </style>

17 </head>

18 <body onload="async_test(testOverlayVisibility)">

19 <div id="v1" class="video-group">

20 <video src="resources/test-positive-start-time.webm"

21 class="should-not-have-overlay-btn"></video>

22 <div class="overlay"></div>

23 </div>

24 <div id="v2" class="video-group">

25 <video src="resources/test-positive-start-time.webm"

26 class="should-have-overlay-btn"></video>

27 </div>

28 <script>

29 function testOverlayVisibility(test) {

30 var videos = document.getElementsByTagName('video');

31 for (var i = 0; i < videos.length; i++) {

32 internals.mediaPlayerRemoteRouteAvailabilityChanged(videos[i], t rue);

33

34 assert_equals(isCastButtonVisible(videos[i]),

35 videos[i].classList.contains('should-have-overlay- btn'),

36 videos[i].parentNode.id + ' - overlay cast button visibility error.');

37 };

38

39 test.done();

40 }

41

42 function isCastButtonVisible(videoElement)

43 {

44 var btn = overlayCastButton(videoElement);

45 return btn.style.display != 'none' && btn.style.visibility != 'hidde n';

46 }

47 </script>

48 </body>

49 </html>

OLD	NEW