Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2846473002: (reland) Optimize check_gn_headers.py for speed (Closed)

Created:
3 years, 8 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

(reland) Optimize check_gn_headers.py for speed - Process the output of 'ninja' live through the pipe rather than waiting for it to finish. - Use multiprocessing. Benchmark results using pypy: Before: 17.10user 14.38system 0:20.05elapsed 157%CPU (0avgtext+0avgdata 1708036maxresident)k 18.06user 15.63system 0:21.92elapsed 153%CPU (0avgtext+0avgdata 1710912maxresident)k 17.94user 13.72system 0:19.91elapsed 158%CPU (0avgtext+0avgdata 1172128maxresident)k After: 15.28user 7.11system 0:06.25elapsed 357%CPU (0avgtext+0avgdata 319236maxresident)k 16.03user 7.74system 0:06.84elapsed 347%CPU (0avgtext+0avgdata 319396maxresident)k 15.24user 8.16system 0:06.36elapsed 367%CPU (0avgtext+0avgdata 318272maxresident)k BUG=661774 Review-Url: https://codereview.chromium.org/2842513003 Cr-Original-Commit-Position: refs/heads/master@{#466900} Review-Url: https://codereview.chromium.org/2846473002 Cr-Commit-Position: refs/heads/master@{#467604} Committed: https://chromium.googlesource.com/chromium/src/+/ef74ec9973e071da2dc5813f0b93662a0f1497bf

Patch Set 1 : import from https://crrev.com/2842513003/ #

Patch Set 2 : fix bug in previous round #

Patch Set 3 : use multiprocessing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -13 lines) Patch
M build/check_gn_headers.py View 1 2 6 chunks +42 lines, -11 lines 0 comments Download
M build/check_gn_headers_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
wychen
PTAL
3 years, 8 months ago (2017-04-26 14:20:47 UTC) #2
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-26 19:26:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846473002/40001
3 years, 8 months ago (2017-04-27 06:17:48 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 06:29:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ef74ec9973e071da2dc5813f0b93...

Powered by Google App Engine
This is Rietveld 408576698