Description(reland) Optimize check_gn_headers.py for speed
- Process the output of 'ninja' live through the pipe rather than
waiting for it to finish.
- Use multiprocessing.
Benchmark results using pypy:
Before:
17.10user 14.38system 0:20.05elapsed 157%CPU (0avgtext+0avgdata 1708036maxresident)k
18.06user 15.63system 0:21.92elapsed 153%CPU (0avgtext+0avgdata 1710912maxresident)k
17.94user 13.72system 0:19.91elapsed 158%CPU (0avgtext+0avgdata 1172128maxresident)k
After:
15.28user 7.11system 0:06.25elapsed 357%CPU (0avgtext+0avgdata 319236maxresident)k
16.03user 7.74system 0:06.84elapsed 347%CPU (0avgtext+0avgdata 319396maxresident)k
15.24user 8.16system 0:06.36elapsed 367%CPU (0avgtext+0avgdata 318272maxresident)k
BUG=661774
Review-Url: https://codereview.chromium.org/2842513003
Cr-Original-Commit-Position: refs/heads/master@{#466900}
Review-Url: https://codereview.chromium.org/2846473002
Cr-Commit-Position: refs/heads/master@{#467604}
Committed: https://chromium.googlesource.com/chromium/src/+/ef74ec9973e071da2dc5813f0b93662a0f1497bf
Patch Set 1 : import from https://crrev.com/2842513003/ #Patch Set 2 : fix bug in previous round #Patch Set 3 : use multiprocessing #
Dependent Patchsets: Messages
Total messages: 9 (5 generated)
|