Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2846433002: Disable Clear Browsing Data button in History for guest profiles (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Disable Clear Browsing Data button in History for guest profiles Following the switch to MD Settings, the Clear Browsing Data dialog is not accessible from guest profiles -- instead, closing the session is the primary way to delete the guest's data. This CL disables the Clear Browsing Data button in the History page, which otherwise would open MD Settings with no CBD dialog visible. BUG=694394 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817813004 Cr-Commit-Position: refs/heads/master@{#465154} (cherry picked from commit dcf200334b52ac07d81baaec5257e4a964fa3137) Review-Url: https://codereview.chromium.org/2846433002 . Cr-Commit-Position: refs/branch-heads/3071@{#215} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e9aaf57d85c09c987b5a23bb3c6eff1339d888f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/resources/md_history/side_bar.html View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.js View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tsergeant
3 years, 8 months ago (2017-04-26 01:02:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e9aaf57d85c09c987b5a23bb3c6eff1339d888f8.

Powered by Google App Engine
This is Rietveld 408576698