Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2817813004: Disable entrypoints to Clear Browsing Data from guest profiles (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Clear Browsing Data button in History for guest profiles Following the switch to MD Settings, the Clear Browsing Data dialog is not accessible from guest profiles -- instead, closing the session is the primary way to delete the guest's data. This CL disables the Clear Browsing Data button in the History page, which otherwise would open MD Settings with no CBD dialog visible. BUG=694394 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817813004 Cr-Commit-Position: refs/heads/master@{#465154} Committed: https://chromium.googlesource.com/chromium/src/+/dcf200334b52ac07d81baaec5257e4a964fa3137

Patch Set 1 #

Patch Set 2 : Remove non-history change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/resources/md_history/side_bar.html View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.js View 2 chunks +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
tsergeant
This needs to go to M59, so I'd appreciate if you could take a look ...
3 years, 8 months ago (2017-04-13 03:17:44 UTC) #4
calamity
lgtm. Sorry, didn't see this.
3 years, 8 months ago (2017-04-18 01:44:42 UTC) #6
Dan Beam
sweet, thanks for the quick fixes for this and the app menu command item
3 years, 8 months ago (2017-04-18 05:08:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817813004/40001
3 years, 8 months ago (2017-04-18 05:11:49 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 06:23:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dcf200334b52ac07d81baaec5257...

Powered by Google App Engine
This is Rietveld 408576698