Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2846403002: Revert of MediaRecorder: enable encode acceleration for VP8 in Android (Closed)

Created:
3 years, 7 months ago by Khushal
Modified:
3 years, 7 months ago
Reviewers:
emircan, mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, jam, darin-cc_chromium.org, mcasas+mediarecorder_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MediaRecorder: enable encode acceleration for VP8 in Android (patchset #1 id:40001 of https://codereview.chromium.org/2852583002/ ) Reason for revert: Speculatively reverting since WebRtcMediaRecorderTest.PeerConnection tests on Marshmallow 64 bit Tester have become flaky since the patch landed. Original issue's description: > MediaRecorder: enable encode acceleration for VP8 in Android > > This is a refry of https://crrev.com/2801803002 (as pointed out > in https://crrev.com/2836013006) that enables only VP8 > hardware encoding in Android. > > Tested via webrtc_media_recorder_browsertest.cc [1] > > [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_recorder_browsertest.cc?q=webrtc+mediarecorder&sq=package:chromium&dr=CSs&l=27 > > BUG=638664 > > Review-Url: https://codereview.chromium.org/2852583002 > Cr-Commit-Position: refs/heads/master@{#467879} > Committed: https://chromium.googlesource.com/chromium/src/+/6089c73618b3b5010bdb81441c6f5f58936f9e58 TBR=emircan@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638664 Review-Url: https://codereview.chromium.org/2846403002 Cr-Commit-Position: refs/heads/master@{#468204} Committed: https://chromium.googlesource.com/chromium/src/+/180f998580b636654b08b415fa33f00c441dc3d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M content/renderer/media_recorder/video_track_recorder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder.cc View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Khushal
Created Revert of MediaRecorder: enable encode acceleration for VP8 in Android
3 years, 7 months ago (2017-04-29 01:15:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846403002/1
3 years, 7 months ago (2017-04-29 01:15:37 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 01:16:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/180f998580b636654b08b415fa33...

Powered by Google App Engine
This is Rietveld 408576698