Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2846363003: Introduce ClassicPendingScript::is_external_ explicitly (Closed)

Created:
3 years, 7 months ago by hiroshige
Modified:
3 years, 4 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ClassicPendingScript::is_external_ explicitly To clarify whether it is external, and to reduce dependency to GetResource() and possibly allow us to clear the Resource earlier. BUG=686281

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : Rebase #

Patch Set 4 : fix = Gerrit Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 2 3 5 chunks +7 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (9 generated)
hiroshige
PTAL.
3 years, 7 months ago (2017-04-29 01:41:18 UTC) #5
sof
https://codereview.chromium.org/2846363003/diff/20001/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp File third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp (right): https://codereview.chromium.org/2846363003/diff/20001/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp#newcode177 third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp:177: if (is_external_) { Why is this (and all the ...
3 years, 7 months ago (2017-04-29 15:01:10 UTC) #9
hiroshige
3 years, 4 months ago (2017-08-04 23:07:43 UTC) #12

Powered by Google App Engine
This is Rietveld 408576698