Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/Source/core/dom/ClassicPendingScript.h

Issue 2846363003: Introduce ClassicPendingScript::is_external_ explicitly (Closed)
Patch Set: fix = Gerrit Patch Set 1 Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ClassicPendingScript.h
diff --git a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
index 1adb11714735f8fe6446aaf46e20a3be6a7c7238..0eabf9677c02d634142b2504ae1df57dea328160 100644
--- a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
+++ b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
@@ -50,7 +50,7 @@ class CORE_EXPORT ClassicPendingScript final
ClassicScript* GetSource(const KURL& document_url,
bool& error_occurred) const override;
bool IsReady() const override;
- bool IsExternal() const override { return GetResource(); }
+ bool IsExternal() const override { return is_external_; }
bool ErrorOccurred() const override;
bool WasCanceled() const override;
bool StartStreamingIfPossible(ScriptStreamer::Type, WTF::Closure) override;
@@ -96,6 +96,7 @@ class CORE_EXPORT ClassicPendingScript final
// MemoryCoordinatorClient
void OnPurgeMemory() override;
+ const bool is_external_;
ReadyState ready_state_;
bool integrity_failure_;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698