Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2846263002: Add FrameView::MarkViewportConstrainedObjectsForLayout (Closed)

Created:
3 years, 7 months ago by szager1
Modified:
3 years, 7 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FrameView::MarkViewportConstrainedObjectsForLayout A minor refactoring; the method will get a couple of other callers in subsequent patches (which I'm breaking up for digestibility). The new condition is something that currently will never be false; subsequent patches will cause it be false sometimes. BUG=701575 Review-Url: https://codereview.chromium.org/2846263002 Cr-Commit-Position: refs/heads/master@{#468066} Committed: https://chromium.googlesource.com/chromium/src/+/90f1043d53ecd259599da1af4a17ca1a1b0a3164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
szager1
3 years, 7 months ago (2017-04-28 15:57:14 UTC) #5
skobes
lgtm
3 years, 7 months ago (2017-04-28 15:59:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846263002/1
3 years, 7 months ago (2017-04-28 18:19:44 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:28:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90f1043d53ecd259599da1af4a17...

Powered by Google App Engine
This is Rietveld 408576698