Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2846073002: Use ScopedTaskEnvironment instead of MessageLoopForUI in ios tests. (Closed)

Created:
1 year, 10 months ago by fdoray
Modified:
1 year, 10 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoopForUI in ios tests. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=marq@chromium.org Review-Url: https://codereview.chromium.org/2846073002 Cr-Commit-Position: refs/heads/master@{#467968} Committed: https://chromium.googlesource.com/chromium/src/+/bc23556815ace00e5f26b5e3d63d07cf8eafabd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller_unittest.mm View 3 chunks +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm View 3 chunks +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm View 3 chunks +6 lines, -2 lines 0 comments Download
M ios/web/webui/url_fetcher_block_adapter_unittest.mm View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
fdoray
1 year, 10 months ago (2017-04-27 18:32:34 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
1 year, 10 months ago (2017-04-27 18:32:36 UTC) #3
gab
lgtm
1 year, 10 months ago (2017-04-28 01:30:04 UTC) #7
marq (ping after 24h)
lgtm
1 year, 10 months ago (2017-04-28 07:45:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846073002/1
1 year, 10 months ago (2017-04-28 12:31:52 UTC) #10
commit-bot: I haz the power
1 year, 10 months ago (2017-04-28 12:36:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc23556815ace00e5f26b5e3d63d...

Powered by Google App Engine
This is Rietveld 408576698