Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm

Issue 2846073002: Use ScopedTaskEnvironment instead of MessageLoopForUI in ios tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm
index d11f286be24a80cdf878f63b6625f6d33762e065..7fbc7a807838452b1dc06a9a09abfbe314fc5718 100644
--- a/ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm
@@ -8,7 +8,7 @@
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
-#include "base/message_loop/message_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/pref_registry/pref_registry_syncable.h"
#include "components/prefs/pref_member.h"
@@ -42,6 +42,10 @@ const char kLanguage2[] = "pirate";
class TranslateCollectionViewControllerTest
: public CollectionViewControllerTest {
protected:
+ TranslateCollectionViewControllerTest()
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI) {}
+
void SetUp() override {
CollectionViewControllerTest::SetUp();
pref_service_ = CreateLocalState();
@@ -66,7 +70,7 @@ class TranslateCollectionViewControllerTest
return factory.Create(registry.get());
}
- base::MessageLoopForUI message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
std::unique_ptr<PrefService> pref_service_;
};

Powered by Google App Engine
This is Rietveld 408576698